chore: remove redundant calls to GetSlice #4635
Merged
+10
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostasrim
reviewed
Feb 20, 2025
| auto& db_slice = op_args.GetDbSlice(); | ||
|
|
||
| DbSlice::Iterator it = DbSlice::Iterator::FromPrime(prime_it); | ||
| if (prime_it->second.HasExpire()) { | ||
| it = db_slice.ExpireIfNeeded(op_args.db_cntx, it).it; | ||
| if (!IsValid(it)) |
There was a problem hiding this comment.
We do a deep copy within FromPrime right ? We can avoid it. ExpireIfNeeded is overloaded and it accepts a (PrimeIterator). If we return false below we avoided an allocation
There was a problem hiding this comment.
Also second question, don't we need IsValid() below regardless ?
There was a problem hiding this comment.
can we pass an invalid iterator to ScanCb? I remember that @adiholden fixed a bug recently around this area
There was a problem hiding this comment.
@romange I do not know that's why I asked. Also we can avoid the copy within FromPrime if we call ExpireIfNeeded(const Context& cntx, PrimeIterator it) right ?
There was a problem hiding this comment.
we can not pass invalid iterator to scancb
adiholden
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.