Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use macos-14 for the daily macos build #4609

Merged
merged 9 commits into from
Feb 17, 2025
Merged

chore: use macos-14 for the daily macos build #4609

merged 9 commits into from
Feb 17, 2025

Conversation

kostasrim
Copy link
Contributor

@kostasrim kostasrim commented Feb 13, 2025

  • bump up to macos-14

rdb_test.Reload no longer crashes with ___chkstk_darwin on the newer version. Neither on my mac as well.

I would really like to know why it crashes with check stack. Funny thing is that the test creates a single key hash map with only a small element. We have unit tests with higher load that did not even trigger this 🤔

@kostasrim kostasrim changed the title [ignore] try macos [ignore] try macos14 Feb 13, 2025

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@kostasrim kostasrim changed the title [ignore] try macos14 chore: use macos-14 for the daily macos build Feb 14, 2025
@kostasrim kostasrim self-assigned this Feb 14, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@kostasrim kostasrim requested a review from romange February 14, 2025 15:35
@kostasrim
Copy link
Contributor Author

https://github.com/dragonflydb/dragonfly/actions/workflows/daily-builds.yml 🍏 (Run it one mroe time just in case)

@romange romange merged commit fe0da9c into main Feb 17, 2025
13 checks passed
@romange romange deleted the kpr5 branch February 17, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants