test: added test_keys_expiration_during_migration #4558
Merged
+64
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adiholden
reviewed
Feb 12, 2025
adiholden
reviewed
Feb 12, 2025
adiholden
reviewed
Feb 12, 2025
BorysTheDev
force-pushed
the
test_keys_expiration_during_migration
branch
from
2c4cd35 to
b90f3e1
Compare
adiholden
reviewed
Feb 13, 2025
tests/dragonfly/utility.py
Outdated
| for i in range(0, self.batch_size): | ||
| pipeline.execute_command(f"SET tmp{self.i} bar{self.i} EX {self.timeout}") | ||
| await client.execute_command(f"SET tmp{self.i} bar{self.i} EX {self.timeout}") |
There was a problem hiding this comment.
There is a reason for using pipeline here, dont remove it... use client.pipeline(transaction=False)
Using pipeline we send commands in batch, this is much faster
There was a problem hiding this comment.
you wanted to avoid multi/exec @adiholden ? 😄
There was a problem hiding this comment.
I did not want to avoid multi exec.
My comment here was that this code is incorrect for cluster as the multi exec in this flow has cross slots commands.
using client.pipeline(transaction=False) is not multi exec , it is just pipeline
There was a problem hiding this comment.
I've rebase with fix for CROSSSLOT and it works
BorysTheDev
force-pushed
the
test_keys_expiration_during_migration
branch
from
8ac628b to
cd89b48
Compare
adiholden
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added test_keys_expiration_during_migration