Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/runtime #11400

Merged
merged 4 commits into from
May 21, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 18, 2024

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: d9f5b309-084f-43b5-02de-08d8b80548e4
  • Build: 20240519.2
  • Date Produced: May 20, 2024 8:56:12 AM UTC
  • Commit: 5f067ce8b50087e032d13a1b97ae5ec39fc54739
  • Branch: refs/heads/main
Microsoft Reviewers: Open in CodeFlow

…0517.30

Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.ComponentModel.Composition , System.ComponentModel.Composition.Registration , System.Configuration.ConfigurationManager , System.Data.Odbc , System.Data.OleDb , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.DirectoryServices.AccountManagement , System.DirectoryServices.Protocols , System.IO.Hashing , System.IO.Packaging , System.IO.Ports , System.Management , System.Reflection.Context , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Runtime.Caching , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceModel.Syndication , System.ServiceProcess.ServiceController , System.Speech , System.Text.Encoding.CodePages , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0
 From Version 9.0.0-preview.5.24265.2 -> To Version 9.0.0-preview.5.24267.30
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner May 18, 2024 12:01
…0518.2

Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.ComponentModel.Composition , System.ComponentModel.Composition.Registration , System.Configuration.ConfigurationManager , System.Data.Odbc , System.Data.OleDb , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.DirectoryServices.AccountManagement , System.DirectoryServices.Protocols , System.IO.Hashing , System.IO.Packaging , System.IO.Ports , System.Management , System.Reflection.Context , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Runtime.Caching , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceModel.Syndication , System.ServiceProcess.ServiceController , System.Speech , System.Text.Encoding.CodePages , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0
 From Version 9.0.0-preview.5.24265.2 -> To Version 9.0.0-preview.5.24268.2
…0519.2

Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.ComponentModel.Composition , System.ComponentModel.Composition.Registration , System.Configuration.ConfigurationManager , System.Data.Odbc , System.Data.OleDb , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.DirectoryServices.AccountManagement , System.DirectoryServices.Protocols , System.IO.Hashing , System.IO.Packaging , System.IO.Ports , System.Management , System.Reflection.Context , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Runtime.Caching , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceModel.Syndication , System.ServiceProcess.ServiceController , System.Speech , System.Text.Encoding.CodePages , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions , VS.Redist.Common.NetCore.SharedFramework.x64.9.0
 From Version 9.0.0-preview.5.24265.2 -> To Version 9.0.0-preview.5.24269.2
@Tanya-Solyanik
Copy link
Member

Tanya-Solyanik commented May 20, 2024

Test input: typeof(IList<ICustomTypeDescriptor>), Array.Empty<string>()

 Message: 
Assert.Equal() Failure: Collections differ
Expected: string[]                                           []
Actual:   IteratorSelectIterator<PropertyDescriptor, string> ["RequireRegisteredTypes"]
                                                              ↑ (pos 0)

at System.Windows.Forms.Tests.ListBindingHelperTests.ListBindingHelper_GetListItemProperties_InvokeObject_ReturnsExpected(Object list, String[] expected) in D:\a_work\1\s\src\System.Windows.Forms\tests\UnitTests\System\Windows\Forms\ListBindingHelperTests.cs:line 292
at InvokeStub_ListBindingHelperTests.ListBindingHelper_GetListItemProperties_InvokeObject_ReturnsExpected(Object, Span`1)
at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

@Tanya-Solyanik
Copy link
Member

Tanya-Solyanik commented May 21, 2024

@LakshanF @steveharter - this test is failing because the ICustomTpeDescriptor interface had been updated with a new property - RequireRegisteredTypes. Does this have to be a Browsable property? https://learn.microsoft.com/en-us/dotnet/api/system.componentmodel.browsableattribute?view=net-8.0

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.26495%. Comparing base (dff9619) to head (616be6c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11400         +/-   ##
===================================================
+ Coverage   74.26463%   74.26495%   +0.00032%     
===================================================
  Files           3025        3025                 
  Lines         626861      626861                 
  Branches       46742       46742                 
===================================================
+ Hits          465536      465538          +2     
+ Misses        157980      157970         -10     
- Partials        3345        3353          +8     
Flag Coverage Δ
Debug 74.26495% <100.00000%> (+0.00032%) ⬆️
integration 17.99135% <ø> (-0.00704%) ⬇️
production 46.99116% <ø> (+0.00070%) ⬆️
test 96.98684% <100.00000%> (ø)
unit 43.97109% <ø> (+0.00139%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik merged commit 23ec4d8 into main May 21, 2024
9 checks passed
@Tanya-Solyanik Tanya-Solyanik deleted the darc-main-dc9509e6-219c-4e5b-b9cb-36f21d03c3c2 branch May 21, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant