Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for TrackBar Accessible Object #11397

Merged

Conversation

Syareel-Sukeri
Copy link
Contributor

@Syareel-Sukeri Syareel-Sukeri commented May 17, 2024

Related #10453

Proposed changes

  • Add unit test for TrackBar Accessible Object in three files: TrackBarAccessibleObjectTests, TrackBarChildAccessibleObjectTests, TrackBarFirstButtonAccessibleObjectTests
  • Test TrackBarAccessibleObjectTests method and property: HitTest, DefaultAction
  • Test TrackBarChildAccessibleObjectTests properties: Role, State
  • Test TrackBarFirstButtonAccessibleObjectTests property: Name
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 88.23529% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 74.26321%. Comparing base (31176a4) to head (5b01587).
Report is 6 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11397         +/-   ##
===================================================
- Coverage   74.27181%   74.26321%   -0.00861%     
===================================================
  Files           3025        3025                 
  Lines         626861      626912         +51     
  Branches       46742       46744          +2     
===================================================
- Hits          465581      465565         -16     
- Misses        157935      157992         +57     
- Partials        3345        3355         +10     
Flag Coverage Δ
Debug 74.26321% <88.23529%> (-0.00861%) ⬇️
integration 17.98995% <ø> (-0.01196%) ⬇️
production 46.98484% <ø> (-0.01265%) ⬇️
test 96.98554% <88.23529%> (-0.00862%) ⬇️
unit 43.96547% <ø> (-0.00246%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@ricardobossan ricardobossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than failing check due to seemingly unrelated code, LGTM.

@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label May 21, 2024
@Syareel-Sukeri
Copy link
Contributor Author

All checks have passed and asking for a review

@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label May 21, 2024
@Tanya-Solyanik Tanya-Solyanik merged commit b7570a2 into dotnet:main May 22, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview5 milestone May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants