Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for ComboBox #11381

Merged
merged 5 commits into from
May 23, 2024

Conversation

Nora-Zhou01
Copy link
Member

@Nora-Zhou01 Nora-Zhou01 commented May 16, 2024

Related #10453

Proposed changes

  • Add unit tests for ComboBox to test its properties: AutoCompleteCustomSource, SelectedText
  • Add unit test for stability and reliability of ComboBox in EndUpdate and BeginUpdate settings
Microsoft Reviewers: Open in CodeFlow

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.29395%. Comparing base (bde3c80) to head (a3b9204).
Report is 116 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11381         +/-   ##
===================================================
- Coverage   74.35458%   74.29395%   -0.06064%     
===================================================
  Files           3009        3026         +17     
  Lines         624977      627152       +2175     
  Branches       46497       46758        +261     
===================================================
+ Hits          464699      465936       +1237     
- Misses        156874      157870        +996     
+ Partials        3404        3346         -58     
Flag Coverage Δ
Debug 74.29395% <100.00000%> (-0.06064%) ⬇️
integration 17.99823% <ø> (-0.36917%) ⬇️
production 47.03027% <ø> (+0.06141%) ⬆️
test 96.98768% <100.00000%> (-0.07745%) ⬇️
unit 44.00946% <ø> (+0.09678%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@elachlan elachlan added the waiting-review This item is waiting on review by one or more members of team label May 17, 2024
@Tanya-Solyanik Tanya-Solyanik added 📭 waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels May 21, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label May 22, 2024
@elachlan elachlan added the waiting-review This item is waiting on review by one or more members of team label May 22, 2024
Tanya-Solyanik
Tanya-Solyanik previously approved these changes May 22, 2024
@Tanya-Solyanik Tanya-Solyanik removed the waiting-review This item is waiting on review by one or more members of team label May 22, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small comments, otherwise LGTM

@lonitra lonitra added the 📭 waiting-author-feedback The team requires more information from the author label May 22, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label May 23, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lonitra lonitra merged commit f53f153 into dotnet:main May 23, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview6 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants