Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for ListView #11380

Merged
merged 4 commits into from
May 22, 2024

Conversation

MandiMan
Copy link
Contributor

@MandiMan MandiMan commented May 16, 2024

Related #10453

Proposed changes

  • Add unit tests for ListView to test its events: TextChanged, AfterLabelEdit, BeforeLabelEdit, CacheVirtualItems
Microsoft Reviewers: Open in CodeFlow

@MandiMan MandiMan requested a review from a team as a code owner May 16, 2024 01:50
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.27990%. Comparing base (74caf32) to head (dcab039).
Report is 15 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11380         +/-   ##
===================================================
+ Coverage   74.26878%   74.27990%   +0.01111%     
===================================================
  Files           3025        3026          +1     
  Lines         626861      627027        +166     
  Branches       46742       46753         +11     
===================================================
+ Hits          465562      465755        +193     
+ Misses        157959      157919         -40     
- Partials        3340        3353         +13     
Flag Coverage Δ
Debug 74.27990% <100.00000%> (+0.01111%) ⬆️
integration 17.99171% <ø> (-0.01301%) ⬇️
production 47.00906% <ø> (+0.01824%) ⬆️
test 96.98831% <100.00000%> (-0.00585%) ⬇️
unit 43.98724% <ø> (+0.05160%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@SimonZhao888 SimonZhao888 added the 📭 waiting-author-feedback The team requires more information from the author label May 16, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label May 17, 2024
SimonZhao888
SimonZhao888 previously approved these changes May 20, 2024
@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label May 20, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label May 21, 2024
@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label May 21, 2024
@dotnet-policy-service dotnet-policy-service bot removed the 📭 waiting-author-feedback The team requires more information from the author label May 22, 2024
@lonitra lonitra merged commit 9014e59 into dotnet:main May 22, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview6 milestone May 22, 2024
@MandiMan MandiMan deleted the Add-code-coverage-for-ListView branch May 24, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants