Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for TreeView #11361

Merged
merged 4 commits into from
May 21, 2024

Conversation

Zheng-Li01
Copy link
Member

@Zheng-Li01 Zheng-Li01 commented May 13, 2024

related #10453

Proposed changes

  • Add unit tests for TreeView to test its properties:TopNode, accessibilityObject, ItemHeight,Indent
  • Add unit tests for TreeView to test its methods: ConvertTo, CollapseAll, ExpandAll, GetNodeCount, ShouldSerializeIndent, shouldSerializeItemHeightMethod, ToString

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.28680%. Comparing base (9f8f671) to head (2f8afe1).
Report is 3 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11361         +/-   ##
===================================================
+ Coverage   74.27085%   74.28680%   +0.01595%     
===================================================
  Files           3025        3026          +1     
  Lines         626861      626966        +105     
  Branches       46742       46753         +11     
===================================================
+ Hits          465575      465753        +178     
+ Misses        157937      157868         -69     
+ Partials        3349        3345          -4     
Flag Coverage Δ
Debug 74.28680% <100.00000%> (+0.01595%) ⬆️
integration 18.00648% <ø> (+0.01476%) ⬆️
production 47.02100% <ø> (+0.02562%) ⬆️
test 96.99508% <100.00000%> (+0.00092%) ⬆️
unit 43.99110% <ø> (+0.02106%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik
Copy link
Member

@Zheng-Li01 - feel free to use only the Proposed changes section in the PR description, the rest is not applicable to new test cases

@Zheng-Li01 Zheng-Li01 added the waiting-review This item is waiting on review by one or more members of team label May 13, 2024
@Epica3055
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LeafShi1
Copy link
Member

LGTM! @Tanya-Solyanik Please review this again

Copy link
Member

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit 3ba919b into dotnet:main May 21, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0 Preview5 milestone May 21, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label May 21, 2024
@Zheng-Li01 Zheng-Li01 deleted the Add_test_coverage_for_TreeView branch May 21, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants