Expand EOL list to include net7 6 months after it goes OOS per design #43440
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
|
/backport to release/9.0.1xx |
|
Started backporting to release/9.0.1xx: https://github.com/dotnet/sdk/actions/runs/10855800411 |
Disable the EOL message for two publishing tests
joeloff
approved these changes
Sep 16, 2024
|
@MichalStrehovsky @LakshanF I went ahead and just disabled the new warning in the two AOT tests that hit net7. Let me know if you've rather just have those tests no longer target net 7. I make the change here and #43441. The plan is to merge for GA. |
MiYanni
approved these changes
Sep 17, 2024
marcpopMSFT
added
the
breaking-change
|
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a version of .NET goes out of support, we add a gold bar in Visual Studio when customers open a project targeting that version and we mark it out of support in the UI. However, to give customers time to migration, we don't mark it as a warning in builds for 6 months as otherwise, customers with warnings as errors would be broken immediately.
Customer Impact
Customers targeting net7.0 will get a warning that the runtime is out of support. They can upgrade, suppress the warning, or set a property to disable the warning.
Regression
Intentional change
Testing
Automated. Had to modify a few tests to remove the net7.0 targeting or disable the warning.
Risk
Low.