Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable msbuild terminal logger for dotnet test #38098

Merged
merged 12 commits into from
Jan 19, 2024

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Jan 18, 2024

Enable terminal logger, and the new MSBuild test logger integration by default for dotnet test.

image

--property:VSTestUseMSBuildOutput=false can be used to opt out from both terminal logger and the new msbuild logger.

image

-tl:false can be used to opt out from terminal logger, but keep using the new msbuild logger.

image

@nohwnd nohwnd requested a review from a team as a code owner January 18, 2024 13:27
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-DotNet Test untriaged Request triage from a team member labels Jan 18, 2024
@nohwnd
Copy link
Member Author

nohwnd commented Jan 19, 2024

@tmat @arkalyanms Please approve so it can get into preview 1.

@nohwnd
Copy link
Member Author

nohwnd commented Jan 19, 2024

@marcpopMSFT this unifies the experience of dotnet test with other commands that use terminal logger. If you can, please approve so we can have it in preview1. Thanks!

@nohwnd nohwnd merged commit 65ce320 into dotnet:main Jan 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-DotNet Test untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants