Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0] CI: runtime-wasm-perf: disable for PRs #92977

Merged
merged 1 commit into from Oct 4, 2023
Merged

[release/8.0] CI: runtime-wasm-perf: disable for PRs #92977

merged 1 commit into from Oct 4, 2023

Conversation

radical
Copy link
Member

@radical radical commented Oct 3, 2023 •
edited

Since we have runtime-wasm-perf enabled for PRs now, it needs a corresponding pr: none in the yml to disable it for this branch.

@radical radical added the arch-wasm WebAssembly architecture label Oct 3, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 3, 2023
@radical radical changed the title CI: runtime-wasm-perf: disable for PRs [release/8.0] CI: runtime-wasm-perf: disable for PRs Oct 3, 2023
@ghost ghost assigned radical Oct 3, 2023
@ghost
Copy link

ghost commented Oct 3, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: radical
Assignees: -
Labels:

arch-wasm
Milestone: -

@ghost
Copy link

ghost commented Oct 3, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Since we have runtime-wasm-perf enabled for PRs now, it needs a corresponding pr: none in the yml to disable it for this branch.

Author: radical
Assignees: radical
Labels:

arch-wasm, area-Infrastructure-mono, needs-area-label
Milestone: -

@dougbu
Copy link
Member

dougbu commented Oct 3, 2023

likely need the same for release/6.0 and release/7.0

@radical
Copy link
Member Author

radical commented Oct 4, 2023

likely need the same for release/6.0 and release/7.0

7.0: #92978
6.0: the pipeline wasn't defined for this branch

@radical radical added Servicing-consider Issue for next servicing release review and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 4, 2023
carlossanlop
carlossanlop approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tell mode. Approved.

@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 4, 2023
@carlossanlop carlossanlop merged commit a84f8ff into dotnet:release/8.0 Oct 4, 2023
172 of 184 checks passed
@radical radical deleted the runtime-wasm-perf-triggers-8 branch October 4, 2023 19:31
@ghost ghost locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

@dougbu dougbu dougbu approved these changes

@lewing lewing Awaiting requested review from lewing

@steveisok steveisok Awaiting requested review from steveisok

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono Servicing-approved Approved for servicing release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@radical @dougbu @carlossanlop