[release/8.0] Update dependencies from dotnet/roslyn

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

• Subscription: ac2d12d7-7c98-40fe-ec67-08db9e4ff4ff
• Build: 20231001.1
• Date Produced: October 2, 2023 3:27:34 AM UTC
• Commit: 0d735148bbb4cb511be547fbc1db63a2c81a821d
• Branch: refs/heads/release/dev17.8

• Updates:
  • Microsoft.CodeAnalysis: from 4.8.0-3.23472.2 to 4.8.0-3.23501.1
  • Microsoft.CodeAnalysis.CSharp: from 4.8.0-3.23472.2 to 4.8.0-3.23501.1
  • Microsoft.Net.Compilers.Toolset: from 4.8.0-3.23472.2 to 4.8.0-3.23501.1

[lewing]

@dotnet/roslyn roslyn update seems to be causing failures

[genlu]

@lewing what's the error message? Not sure where to find them

[lewing]

https://dev.azure.com/dnceng-public/public/_build/results?buildId=420429&view=logs&j=3087b8b9-b9da-5b2b-e6fa-b58c34928353&t=e51684b8-3fa0-51cb-c640-5d23891ff33c&l=632

/__w/1/s/.packages/microsoft.net.compilers.toolset/4.8.0-3.23477.1/tasks/netcore/Microsoft.CSharp.Core.targets(84,5): error : Unhandled exception. System.MissingMethodException: Method not found: 'System.Collections.Generic.IEnumerator`1<Microsoft.CodeAnalysis.NodeStateEntry`1<System.ValueTuple`2<System.__Canon,System.__Canon>>> Microsoft.CodeAnalysis.NodeStateTable`1.GetEnumerator()'. [/__w/1/s/src/mono/wasm/debugger/BrowserDebugHost/BrowserDebugHost.csproj]
##[error].packages/microsoft.net.compilers.toolset/4.8.0-3.23477.1/tasks/netcore/Microsoft.CSharp.Core.targets(84,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Unhandled exception. System.MissingMethodException: Method not found: 'System.Collections.Generic.IEnumerator`1<Microsoft.CodeAnalysis.NodeStateEntry`1<System.ValueTuple`2<System.__Canon,System.__Canon>>> Microsoft.CodeAnalysis.NodeStateTable`1.GetEnumerator()'.
/__w/1/s/.packages/microsoft.net.compilers.toolset/4.8.0-3.23477.1/tasks/netcore/Microsoft.CSharp.Core.targets(84,5): error :    at Microsoft.CodeAnalysis.ExternalAccess.RazorCompiler.HostOutputNode`1.AppendOutputs(IncrementalExecutionContext context, CancellationToken cancellationToken) [/__w/1/s/src/mono/wasm/debugger/BrowserDebugHost/BrowserDebugHost.csproj]
##[error].packages/microsoft.net.compilers.toolset/4.8.0-3.23477.1/tasks/netcore/Microsoft.CSharp.Core.targets(84,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build)    at Microsoft.CodeAnalysis.ExternalAccess.RazorCompiler.HostOutputNode`1.AppendOutputs(IncrementalExecutionContext context, CancellationToken cancellationToken)
/__w/1/s/.packages/microsoft.net.compilers.toolset/4.8.0-3.23477.1/tasks/netcore/Microsoft.CSharp.Core.targets(84,5): error :    at Microsoft.CodeAnalysis.GeneratorDriver.UpdateOutputs(ImmutableArray`1 outputNodes, IncrementalGeneratorOutputKind outputKind, Builder generatorRunStateBuilder, CancellationToken cancellationToken, Builder driverStateBuilder) [/__w/1/s/src/mono/wasm/debugger/BrowserDebugHost/BrowserDebugHost.csproj]
##[error].packages/microsoft.net.compilers.toolset/4.8.0-3.23477.1/tasks/netcore/Microsoft.CSharp.Core.targets(84,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build)    at Microsoft.CodeAnalysis.GeneratorDriver.UpdateOutputs(ImmutableArray`1 outputNodes, IncrementalGeneratorOutputKind outputKind, Builder generatorRunStateBuilder, CancellationToken cancellationToken, Builder driverStateBuilder)
/__w/1/s/.packages/microsoft.net.compilers.toolset/4.8.0-3.23477.1/tasks/netcore/Microsoft.CSharp.Core.targets(84,5): error :    at Microsoft.CodeAnalysis.GeneratorDriver.RunGeneratorsCore(Compilation compilation, DiagnosticBag diagnosticsBag, CancellationToken cancellationToken) [/__w/1/s/src/mono/wasm/debugger/BrowserDebugHost/BrowserDebugHost.csproj]

[333fred]

We need to update the SDK that the runtime uses to pull in the new razor compiler here. I'm not sure who coordinates that, @lewing or @carlossanlop do either of you know?

[marek-safar]

I added a commit (0b32a91) to this PR which should hopefully address this.

@GrabYourPitchforks could you please PR the fix to main too

[lewing]

In runtime we typically update the sdk via darc flow from dotnet/arcade to a public build, for some reason release/8.0 hasn't seen arcade flow recently. I've opened #92778 to get the latest darc flow but it doesn't appear that rc1 is new enough for this roslyn based on #92578

[333fred]

but it doesn't appear that rc1 is new enough for this roslyn based on #92578

I think that's true. We'll probably need to for an rc2 build.

[333fred]

@tommcdon, it looks like there's just one System.Diagnostics test failure at this point. Can you advise whether that's an expected flaky failure?

[carlossanlop]

@333fred the System.Diagnostics failure seemed to be unrelated and flaky, it passed after the latest deps flow commit.

@lambdageek @radical there is a Webcil failure. Is it relevant to this PR or can I merge? https://github.com/dotnet/runtime/pull/92503/checks?check_run_id=17332176462

[carlossanlop]

The wasm failure is known and pre-existing, but it did not get linked by KnownBuildError: #92910

Merging now.