Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0] Bring back CopyOutputSymbolsToPublishDirectory #92369

Merged
merged 2 commits into from Sep 29, 2023
Merged

[release/8.0] Bring back CopyOutputSymbolsToPublishDirectory #92369

merged 2 commits into from Sep 29, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 20, 2023 •
edited by agocke

Backport of #92315 to release/8.0

/cc @agocke

Customer Impact

Fixes bug where Native AOT stopped respecting CopyOutputSymbolsToPublishDirectory.

Testing

Manual testing. Unit tests in the SDK have been written, but the SDK requires a new installer build in main, which we haven't gotten since the shift to 9.0.

Risk

Low. Isolated to Native AOT targets files.

agocke and others added 2 commits September 20, 2023 19:49
@agocke
Bring back CopyOutputSymbolsToPublishDirectory
90842b7 
I accidentally removed this property from AOT compilation
when adding support for Mac dsym bundles. This change re-enables
support for suppressing debugging symbols in the output.

Fixes #92188
@agocke @MichalStrehovsky
Update src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Nativ…
6f6df7d 
…e.Publish.targets

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
@ghost
Copy link

ghost commented Sep 20, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #92315 to release/8.0

/cc @agocke

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-NativeAOT-coreclr
Milestone: -

@carlossanlop
Copy link
Member

carlossanlop commented Sep 21, 2023 •
edited

@agocke this is targeting release/8.0. Is that intended? There's still time to target release/8.0-rc2 (you can change branch by editing the title, just letting you know in case you were not aware of that functionality).

Once the template is filled, please send an email to Tactics requesting approval. cc @jeffschwMSFT

jeffschwMSFT
jeffschwMSFT approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we will take for consideration in 8.0.x

@jeffschwMSFT jeffschwMSFT added the Servicing-consider Issue for next servicing release review label Sep 28, 2023
@jeffschwMSFT jeffschwMSFT added this to the 8.0.0 milestone Sep 28, 2023
@agocke agocke added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 28, 2023
@agocke
Copy link
Member

agocke commented Sep 28, 2023

@carlossanlop This is ready to merge

@carlossanlop carlossanlop merged commit 2227dc8 into release/8.0 Sep 29, 2023
110 of 115 checks passed
@carlossanlop carlossanlop deleted the backport/pr-92315-to-release/8.0 branch September 29, 2023 00:58
@radical radical mentioned this pull request Oct 3, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Oct 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffschwMSFT jeffschwMSFT jeffschwMSFT approved these changes

@MichalStrehovsky MichalStrehovsky MichalStrehovsky approved these changes

Assignees
No one assigned
Labels
area-NativeAOT-coreclr Servicing-approved Approved for servicing release
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@carlossanlop @agocke @jeffschwMSFT @MichalStrehovsky