Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0-rc1] [release/8.0] Fix wasi build. #92368

Merged
merged 3 commits into from
Sep 20, 2023
Merged

[release/8.0-rc1] [release/8.0] Fix wasi build. #92368

merged 3 commits into from
Sep 20, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #92232 to release/8.0-rc1

/cc @radical @github-actions[bot]

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 20, 2023
@radical radical added Servicing-consider Issue for next servicing release review arch-wasm WebAssembly architecture area-Build-mono os-wasi Related to WASI variant of arch-wasm labels Sep 20, 2023
@ghost
Copy link

ghost commented Sep 20, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #92232 to release/8.0-rc1

/cc @radical @github-actions[bot]

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

Servicing-consider, arch-wasm, area-Build-mono, os-wasi, needs-area-label
Milestone: -

@ghost
Copy link

ghost commented Sep 20, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #92232 to release/8.0-rc1

/cc @radical @github-actions[bot]

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

Servicing-consider, arch-wasm, area-Infrastructure-mono, os-wasi, needs-area-label
Milestone: -

@radical radical removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 20, 2023
@mmitche mmitche merged commit f52a295 into release/8.0-rc1 Sep 20, 2023
13 of 141 checks passed
This was referenced Sep 20, 2023
Open
Closed
@jkotas jkotas deleted the backport/pr-92232-to-release/8.0-rc1 branch September 21, 2023 17:19
@radical radical mentioned this pull request Sep 26, 2023
Closed
@radical radical mentioned this pull request Oct 3, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marek-safar marek-safar Awaiting requested review from marek-safar

@mmitche mmitche Awaiting requested review from mmitche

@lewing lewing Awaiting requested review from lewing

Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono os-wasi Related to WASI variant of arch-wasm Servicing-consider Issue for next servicing release review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@radical @mmitche @vargaz