Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DependencyContext splitting on semi-colon #87518

Merged
merged 3 commits into from
Jun 14, 2023

Commits on Jun 13, 2023

  1. Fix DependencyContext splitting on semi-colon

    dotnet@5e67657 introduced a bug in DependencyContextPaths where the static array is not initialized before it is being used in the Create static method.
    
    This fix reorders the fields so that s_semicolon is initialized before it is first used.
    eerhardt committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    476cfea View commit details
    Browse the repository at this point in the history
  2. - Don't cache the semicolon array since it is only used once at startup

    - Skip test on netfx since it doesn't work.
    eerhardt committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    c6026e3 View commit details
    Browse the repository at this point in the history
  3. Address PR feedback

    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    eerhardt and stephentoub committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    e67bb24 View commit details
    Browse the repository at this point in the history