[NativeAOT] Improving HelloiOS sample for NativeAOT to be testable with runtime packs #86652

ivanpovazan · 2023-05-23T16:35:16Z

Description

This PR improves testing NativeAOT iOS build integration by adjusting the build of HelloiOS sample.
The list of changes:

introducing an option to build HelloiOS sample with NativeAOT ios runtime packs (see bellow invocation instructions)
reusing LinkerArg items populated by NativeAOT targets
improving the way AppleAppBuilder passes extra linker arguments to CMake (this avoids weird duplication of linker flags when extra linker arguments are passed along through target_link_libraries)

Instructions

To build/run the app without runtime packs run the following command on a clean checkout
make world TARGET_OS=ios DEPLOY_AND_RUN=true -C src/mono/sample/iOS-NativeAOT
To build/run the app with runtime packs run the following command on a clean checkout:
make world TARGET_OS=ios DEPLOY_AND_RUN=true USE_RUNTIME_PACKS=true -C src/mono/sample/iOS-NativeAOT
- This requires dotnet sdk version 8.0.100-preview.5+ and should be reverted once the testing is done

Current state

Scenario: USE_RUNTIME_PACKS=false on a ios-arm64 device

building
running

Scenario: USE_RUNTIME_PACKS=true on a ios-arm64 device

building
running

Final note

This PR includes changes from: [NativeAOT] Update ILCompiler paths to handle PublishAotUsingRuntimePack=true #85996 to verify the correctness of the change, as there is currently no way to test it otherwise
The intention is not to takeaway the work done by @filipnavara but rather to help with testing it

Contributes to #80911

ivanpovazan · 2023-05-23T16:35:48Z

/cc: @akoeplinger @kotlarmilos

ghost · 2023-05-23T16:36:50Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR is currently marked as draft and should be used just for testing and receiving feedback.

Description

On the long run, it will improve testing NativeAOT iOS build integration by adjusting the build of HelloiOS sample.
The list of changes:

introducing an option to build HelloiOS sample with NativeAOT ios runtime packs (see bellow invocation instructions)
reusing LinkerArg items populated by NativeAOT targets
improving the way AppleAppBuilder passes extra linker arguments to CMake (this avoids weird duplication of linker flags when extra linker arguments are passed along to target_link_libraries)

Instructions

To build/run the app without runtime packs run the following command on a clean checkout
make world TARGET_OS=ios DEPLOY_AND_RUN=true -C src/mono/sample/iOS-NativeAOT
To build/run the app with runtime packs run the following command on a clean checkout:
make world TARGET_OS=ios DEPLOY_AND_RUN=true USE_RUNTIME_PACKS=true -C src/mono/sample/iOS-NativeAOT
- This requires dotnet sdk version 8.0.100-preview.5+ and should be reverted once the testing is done

Current state

Scenario: USE_RUNTIME_PACKS=false on a ios-arm64 device

building
running

Scenario: USE_RUNTIME_PACKS=true on a ios-arm64 device

building
running crashes on startup -> I am currently investigating the stacktrace

Final note

This PR includes changes from: [NativeAOT] Update ILCompiler paths to handle PublishAotUsingRuntimePack=true #85996 to verify the correctness of the change, as there is currently no way to test it otherwise
The intention is not to takeaway the work done by @filipnavara but rather to help with testing it

Contributes to #80911

Author:	ivanpovazan
Assignees:	ivanpovazan
Labels:	`NO-MERGE`, `os-ios`, `area-NativeAOT-coreclr`
Milestone:	-

ghost · 2023-05-23T16:37:06Z

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR is currently marked as draft and should be used just for testing and receiving feedback.

Description

On the long run, it will improve testing NativeAOT iOS build integration by adjusting the build of HelloiOS sample.
The list of changes:

introducing an option to build HelloiOS sample with NativeAOT ios runtime packs (see bellow invocation instructions)
reusing LinkerArg items populated by NativeAOT targets
improving the way AppleAppBuilder passes extra linker arguments to CMake (this avoids weird duplication of linker flags when extra linker arguments are passed along to target_link_libraries)

Instructions

To build/run the app without runtime packs run the following command on a clean checkout
make world TARGET_OS=ios DEPLOY_AND_RUN=true -C src/mono/sample/iOS-NativeAOT
To build/run the app with runtime packs run the following command on a clean checkout:
make world TARGET_OS=ios DEPLOY_AND_RUN=true USE_RUNTIME_PACKS=true -C src/mono/sample/iOS-NativeAOT
- This requires dotnet sdk version 8.0.100-preview.5+ and should be reverted once the testing is done

Current state

Scenario: USE_RUNTIME_PACKS=false on a ios-arm64 device

building
running

Scenario: USE_RUNTIME_PACKS=true on a ios-arm64 device

building
running crashes on startup -> I am currently investigating the stacktrace

Final note

This PR includes changes from: [NativeAOT] Update ILCompiler paths to handle PublishAotUsingRuntimePack=true #85996 to verify the correctness of the change, as there is currently no way to test it otherwise
The intention is not to takeaway the work done by @filipnavara but rather to help with testing it

Contributes to #80911

Author:	ivanpovazan
Assignees:	ivanpovazan
Labels:	`NO-MERGE`, `os-ios`, `area-NativeAOT-coreclr`
Milestone:	-

ivanpovazan · 2023-05-24T18:31:12Z

@MichalStrehovsky it seems b412b6b introduced a regression for building and running the HelloiOS sample with NativeAOT on a device (in both debug and release configuration).

I have confirmed this by checking out the commit and building and running the app before and after I revert the commit in question.
When the commit is included the app crashes on startup with the following stack trace:
https://gist.github.com/ivanpovazan/b9a0eae347a76ea39cf1f943b801a8e1

There is a simple repro which builds everything and runs the app via: make world TARGET_OS=ios DEPLOY_AND_RUN=true USE_RUNTIME_PACKS=true -C src/mono/sample/iOS-NativeAOT
However, if you do not have mac device at hand here is the repro package for ILC:
2828501054_Program.zip

Finally, I will also try to investigate further why this started failing.

PS Just for reference, when we merge this and Filip's PR we should be almost there to setup CI testing so these kind of regressions are caught early on.

MichalStrehovsky · 2023-05-25T02:44:28Z

I have confirmed this by checking out the commit and building and running the app before and after I revert the commit in question.

Hmm, I don't see anything that would explain why there would be a problem on iDevices after this. Note that the commit in question requires a synchronized update in libRuntime, CoreLib, System.Private.TypeLoader, and the AOT compiler (a fundamental data structure was changed that is understood by all of these). I'd expect the stack you're seeing if one of these was stale on your machine.

src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets

filipnavara · 2023-05-25T07:19:33Z

I'd expect the stack you're seeing if one of these was stale on your machine.

It uses runtime packs from a specific .NET package but the ILCompiler is still the live one, right, @ivanpovazan?

ivanpovazan · 2023-05-25T07:22:29Z

@MichalStrehovsky thanks for checking this, I think that is the problem as I updated global.json to a specific version, which means it probably picks up runtime packs before the commit that causes the discrepancy

@filipnavara yeah exactly ^ will try with a newer version of sdk

ivanpovazan · 2023-05-25T10:06:47Z

Using newer sdk solves the issue as noted by: #86652 (comment)

This reverts commit a8665ce.

ivanpovazan · 2023-06-05T14:23:15Z

/azp run runtime-extra-platforms

azure-pipelines · 2023-06-05T14:23:27Z

Azure Pipelines successfully started running 1 pipeline(s).

ivanpovazan · 2023-06-06T16:36:07Z

Many jobs seem to be timing out which is being tracked here: #76454
I will wait to have a healthy state on CI to rerun and verify this can be merged safely.

filipnavara · 2023-06-07T07:42:28Z

#76454

dotnet/arcade#13774 was resolved. Time to retry?

MichalStrehovsky · 2023-06-07T07:44:31Z

Extra-platforms will not succeed without #87203. They've been failing for a couple days during build stage (not a single test gets executed).

filipnavara · 2023-06-07T07:46:29Z

Extra-platforms will not succeed without #87203.

Right. I wanted to point that out too but my fish memory managed to forget it :-)

ivanpovazan · 2023-06-07T08:38:58Z

/azp run runtime,runtime-extra-platforms

azure-pipelines · 2023-06-07T08:39:36Z

Azure Pipelines successfully started running 2 pipeline(s).

filipnavara · 2023-06-07T09:22:45Z

I guess a rebase/merge is necessary since the builds use branch commits and not merge commits in the AzDO configuration?

ivanpovazan · 2023-06-07T09:49:26Z

I guess a rebase/merge is necessary since the builds use branch commits and not merge commits in the AzDO configuration?

Sorry, I am not sure I understand what could be the problem of just rerunning the pipelines?

filipnavara · 2023-06-07T10:03:42Z

Sorry, I am not sure I understand what could be the problem of just rerunning the pipelines?

That you won't get the commit 6e34b5d that was merged to main and fixed the S.T.Json tests that blocked all the NativeAOT pipelines in the build phase.

ivanpovazan · 2023-06-07T10:25:39Z

Sorry, I am not sure I understand what could be the problem of just rerunning the pipelines?

That you won't get the commit 6e34b5d that was merged to main and fixed the S.T.Json tests that blocked all the NativeAOT pipelines in the build phase.

Looking at the checkout before the build at: https://dev.azure.com/dnceng-public/public/_build/results?buildId=298056&view=logs&j=d282b611-679c-5014-3fe6-3a931ade305f&t=7b0acb1d-0623-531c-f6fb-76c84e37bf81&l=677
isn't
HEAD is now at 35aba423fd Merge c9d5543d3aa59c7a5b6a3056b18aea291a67b0f4 into 6e34b5d4e9b16321f37c108fea3aa7e4e04b495a making sure it takes the last-current tip of dotnet/main

filipnavara · 2023-06-07T10:50:30Z

Sorry for false alarm then. It's an option in the AzDO workflows and some other dotnet repositories build the (unmerged) branch (and I would swear that dotnet/runtime did as well).

akoeplinger · 2023-06-07T11:45:49Z

Sorry for false alarm then. It's an option in the AzDO workflows and some other dotnet repositories build the (unmerged) branch (and I would swear that dotnet/runtime did as well).

It was like that a looong time ago but we use the merged-with-main state nowadays.

You'll see it in the checkout step where it says HEAD is now at 35aba423fd Merge c9d5543d3aa59c7a5b6a3056b18aea291a67b0f4 into 6e34b5d4e9b16321f37c108fea3aa7e4e04b495a

filipnavara · 2023-06-07T11:55:43Z

It was like that a looong time ago

Fine, you can call me grandpa Filip then.

(Also, the dotnet/installer repo didn't do that - #83695 (comment) - which was not that long time ago)

ivanpovazan · 2023-06-07T12:19:20Z

Even with the 6e34b5d fix it seems we still hit time-outs in several jobs. Any suggestions on how to proceed with this?

MichalStrehovsky · 2023-06-07T20:48:22Z

Even with the 6e34b5d fix it seems we still hit time-outs in several jobs. Any suggestions on how to proceed with this?

I'm fine merging with these timeouts for NativeAOT. I didn't look at/consider any of the Mono legs though.

SamMonoRT · 2023-06-07T22:53:14Z

Even with the 6e34b5d fix it seems we still hit time-outs in several jobs. Any suggestions on how to proceed with this?

I have kicked off a re-run of the runtime and extra-platforms lanes - you should possibly have a newer set of results by the time you are at your desk tomorrow.

steveisok · 2023-06-07T22:56:27Z

Separately, I think it would be a good idea to add a nativeaot only pipeline so we don't have to kick off the kitchen sink w/ runtime-extra-platforms. This would be similar to /azp run runtime-ioslike.

/cc @akoeplinger

ivanpovazan · 2023-06-08T11:12:50Z

Thank you all very much for your help and assistance.
I went through the latest CI results, all the failures seem unrelated.
Additionally, I have opened tracking issues for noticed failures.

ivanpovazan and others added 7 commits May 23, 2023 12:04

HelloiOS sample improvements and sync with main branch

478e01f

Fix the way we are passing extra linker arguments from AppleAppBuilder

9ca9c3f

Use ILC collected linker arguments for bundling the application

daa1c0c

Use better naming in the Makefile

37b1550

Prepare grounds for PublishAotUsingRuntimePack = true

c94e9f0

Update ILCompiler paths to handle PublishAotUsingRuntimePack=true

9afd5fb

Enable using runtime pack from NuGet

5f2fe86

ivanpovazan added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) os-ios Apple iOS area-NativeAOT-coreclr labels May 23, 2023

ivanpovazan self-assigned this May 23, 2023

ivanpovazan mentioned this pull request May 23, 2023

[nativeaot][tests] Add Native AOT iOS perf scenarios #85317

Merged

This was referenced May 23, 2023

Tracking issue for CI build timeouts #76454

Closed

Build fails with "eng/common/tools.sh: line 474: 537 Segmentation fault" #76759

Open

steveisok requested a review from akoeplinger May 24, 2023 18:41

MichalStrehovsky reviewed May 25, 2023

View reviewed changes

src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.targets Outdated Show resolved Hide resolved

ivanpovazan added 2 commits May 25, 2023 12:04

Use publish instead

08126df

FIXME: revert once testing is finished

a8665ce

ivanpovazan force-pushed the hellios-packs branch from fd14912 to a8665ce Compare May 25, 2023 10:05

ivanpovazan changed the title ~~[WIP] Improving HelloiOS sample for NativeAOT to be testable with runtime packs~~ [NativeAOT] Improving HelloiOS sample for NativeAOT to be testable with runtime packs May 25, 2023

ivanpovazan marked this pull request as ready for review May 25, 2023 10:07

ivanpovazan requested a review from marek-safar as a code owner May 25, 2023 10:07

Revert "FIXME: revert once testing is finished"

c9d5543

This reverts commit a8665ce.

kotlarmilos mentioned this pull request Jun 6, 2023

[mono][tests] Run Mono iOS sample as functional test on the simulator and maccatalyst on Helix #86578

Merged

build-analysis bot mentioned this pull request Jun 6, 2023

[mono][tvos] Failing Vector64/128 tests #87164

Closed

This was referenced Jun 8, 2023

[mono] Tests failing with Failed to find compatible device: arm64-v8a #87267

Closed

System.Net.Requests.Tests, System.Net.Security.Tests failing with Segmentation fault on Debian 10 #87268

Closed

ivanpovazan merged commit 2835110 into dotnet:main Jun 8, 2023
213 of 236 checks passed

build-analysis bot mentioned this pull request Jun 8, 2023

MsQuicPlatformDetectionTests failures in CI #87275

Closed

ivanpovazan mentioned this pull request Jun 8, 2023

[mono] System.IO.Pipes.Tests test fails on linux_bionic-x64 Release AllSubsets_Mono #87279

Closed

ivanpovazan deleted the hellios-packs branch June 9, 2023 12:13

dotnet locked as resolved and limited conversation to collaborators Jul 9, 2023

[NativeAOT] Improving HelloiOS sample for NativeAOT to be testable with runtime packs #86652

[NativeAOT] Improving HelloiOS sample for NativeAOT to be testable with runtime packs #86652

Conversation

ivanpovazan commented May 23, 2023 • edited

Description

Instructions

Current state

Final note

ivanpovazan commented May 23, 2023

ghost commented May 23, 2023

Description

Instructions

Current state

Final note

ghost commented May 23, 2023

Description

Instructions

Current state

Final note

ivanpovazan commented May 24, 2023 • edited

MichalStrehovsky commented May 25, 2023

filipnavara commented May 25, 2023

ivanpovazan commented May 25, 2023 • edited

ivanpovazan commented May 25, 2023

ivanpovazan commented Jun 5, 2023

azure-pipelines bot commented Jun 5, 2023

ivanpovazan commented Jun 6, 2023

filipnavara commented Jun 7, 2023

MichalStrehovsky commented Jun 7, 2023

filipnavara commented Jun 7, 2023

ivanpovazan commented Jun 7, 2023

azure-pipelines bot commented Jun 7, 2023

filipnavara commented Jun 7, 2023

ivanpovazan commented Jun 7, 2023

filipnavara commented Jun 7, 2023 • edited

ivanpovazan commented Jun 7, 2023

filipnavara commented Jun 7, 2023 • edited

akoeplinger commented Jun 7, 2023 • edited

filipnavara commented Jun 7, 2023 • edited

ivanpovazan commented Jun 7, 2023

MichalStrehovsky commented Jun 7, 2023

SamMonoRT commented Jun 7, 2023

steveisok commented Jun 7, 2023

ivanpovazan commented Jun 8, 2023

ivanpovazan commented May 23, 2023 •

edited

ivanpovazan commented May 24, 2023 •

edited

ivanpovazan commented May 25, 2023 •

edited

filipnavara commented Jun 7, 2023 •

edited

filipnavara commented Jun 7, 2023 •

edited

akoeplinger commented Jun 7, 2023 •

edited

filipnavara commented Jun 7, 2023 •

edited