Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract out ParameterBuilder and implement it #85446

Merged
merged 4 commits into from Apr 28, 2023
Merged

Abstract out ParameterBuilder and implement it #85446

merged 4 commits into from Apr 28, 2023

Conversation

buyaa-n
Copy link
Member

@buyaa-n buyaa-n commented Apr 27, 2023

Contributes to #62956
Fixes #83831

  • Abstract out ParameterBuilder and update runtimes accordingly
  • Create ParameterBuilderImpl and save methods parameters

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned buyaa-n Apr 27, 2023
@ghost
Copy link

ghost commented Apr 27, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #62956
Fixes #83831

  • Abstract out ParameterBuilder and update runtimes accordingly
  • Create ParameterBuilderImpl and save methods parameters
Author: buyaa-n
Assignees: -
Labels:

area-System.Reflection, new-api-needs-documentation
Milestone: -

@vargaz
Copy link
Contributor

vargaz commented Apr 27, 2023

The mono changes look ok.

This was referenced Apr 27, 2023
Closed
Open
Closed
jkotas
jkotas approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@buyaa-n @jkotas
Apply suggestions from code review
b8e1ad8 
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@buyaa-n buyaa-n mentioned this pull request Apr 28, 2023
Closed
@buyaa-n
Copy link
Member Author

buyaa-n commented Apr 28, 2023

The failures are unrelated and looks all timed out infra issue tracked with #76454

@buyaa-n buyaa-n merged commit dd95ed8 into dotnet:main Apr 28, 2023
156 of 170 checks passed
@buyaa-n buyaa-n deleted the save_parameter branch April 28, 2023 17:43
@dotnet dotnet locked as resolved and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@steveharter steveharter Awaiting requested review from steveharter

@AaronRobinsonMSFT AaronRobinsonMSFT Awaiting requested review from AaronRobinsonMSFT

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

@buyaa-n buyaa-n

Labels
area-System.Reflection new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make ParameterBuilder abstract
3 participants
@buyaa-n @vargaz @jkotas