Fix simd12_t size #85362
Merged
Fix simd12_t size #85362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Details
public Vector3 Test() => Vector3.Reflect(
new Vector3(3.0f, 1.0f, 1.0f),
new Vector3(3.0f, 1.0f, 1.0f));; Method Program:Test():System.Numerics.Vector3:this
G_M16498_IG01:
vzeroupper
;; size=3 bbWeight=1 PerfScore 1.00
G_M16498_IG02:
vmovups xmm0, xmmword ptr [reloc @RWD00]
vmovups xmm1, xmmword ptr [reloc @RWD00]
vdpps xmm0, xmm0, xmm1, 127
vmulps xmm0, xmm0, xmm1
vmovups xmm1, xmmword ptr [reloc @RWD16]
vmulps xmm0, xmm0, xmm1
vmovups xmm1, xmmword ptr [reloc @RWD00]
vsubps xmm0, xmm1, xmm0
vmovsd qword ptr [rdx], xmm0
vextractps dword ptr [rdx+08H], xmm0, 2
mov rax, rdx
;; size=64 bbWeight=1 PerfScore 39.25
G_M16498_IG03:
ret
;; size=1 bbWeight=1 PerfScore 1.00
-RWD00 dq 3F80000040400000h, DDDDDDDD3F800000h
+RWD00 dq 3F80000040400000h, 000000003F800000h
-RWD16 dq 4000000040000000h, DDDDDDDD40000000h
+RWD16 dq 4000000040000000h, 0000000040000000h
; Total bytes of code: 68
|
tannergooding
approved these changes
Apr 25, 2023
This was referenced Apr 26, 2023
|
Failure is #76454 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sizeof(simd12_t)used to return 16 - that could produce some garbage values in upper 4 bytes, e.g.:; Method Program:Test():System.Numerics.Vector3:this G_M16498_IG01: vzeroupper ;; size=3 bbWeight=1 PerfScore 1.00 G_M16498_IG02: vmovups xmm0, xmmword ptr [reloc @RWD00] vmovups xmm1, xmmword ptr [reloc @RWD00] vdpps xmm0, xmm0, xmm1, 127 vmulps xmm0, xmm0, xmm1 vmovups xmm1, xmmword ptr [reloc @RWD16] vmulps xmm0, xmm0, xmm1 vmovups xmm1, xmmword ptr [reloc @RWD00] vsubps xmm0, xmm1, xmm0 vmovsd qword ptr [rdx], xmm0 vextractps dword ptr [rdx+08H], xmm0, 2 mov rax, rdx ;; size=64 bbWeight=1 PerfScore 39.25 G_M16498_IG03: ret ;; size=1 bbWeight=1 PerfScore 1.00 -RWD00 dq 3F80000040400000h, DDDDDDDD3F800000h +RWD00 dq 3F80000040400000h, 000000003F800000h -RWD16 dq 4000000040000000h, DDDDDDDD40000000h +RWD16 dq 4000000040000000h, 0000000040000000h ; Total bytes of code: 68so I applied the #include "pshpack4.h" fix @tannergooding suggested