Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't re-scan previously visited blocks in helperexpansion.cpp #85201

Merged
merged 4 commits into from Apr 26, 2023
Merged

Don't re-scan previously visited blocks in helperexpansion.cpp #85201

merged 4 commits into from Apr 26, 2023

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Apr 22, 2023

No description provided.

@ghost ghost assigned EgorBo Apr 22, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 22, 2023
@ghost
Copy link

ghost commented Apr 22, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: EgorBo
Assignees: EgorBo
Labels:

area-CodeGen-coreclr
Milestone: -

@EgorBo EgorBo marked this pull request as ready for review April 22, 2023 20:10
@EgorBo
Copy link
Member Author

EgorBo commented Apr 22, 2023 •
edited

@kunalspathak PTAL, that change I proposed for the helper expansion. Currently it is quite fragile and relies on a fact that expansion will put a call into a cold block or manually clear some flag. This PR skips all internal blocks added during expansion. Diffs: I expected to see some small TP improvement but I guess we don't expand helper calls that much.

kunalspathak
kunalspathak requested changes Apr 24, 2023
View reviewed changes
src/coreclr/jit/helperexpansion.cpp Show resolved Hide resolved
src/coreclr/jit/helperexpansion.cpp Outdated Show resolved Hide resolved
src/coreclr/jit/helperexpansion.cpp Show resolved Hide resolved
@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Apr 24, 2023
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Apr 25, 2023
@EgorBo
Copy link
Member Author

EgorBo commented Apr 25, 2023

@kunalspathak thanks for the feedback, I believe I've addressed all comments

kunalspathak
kunalspathak approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EgorBo
Copy link
Member Author

EgorBo commented Apr 26, 2023

failure is #76454

@EgorBo EgorBo merged commit 63a7a13 into dotnet:main Apr 26, 2023
123 of 126 checks passed
@EgorBo EgorBo deleted the minor-tp-improvement branch April 26, 2023 05:34
@build-analysis build-analysis bot mentioned this pull request Apr 26, 2023
Closed
@dotnet dotnet locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kunalspathak kunalspathak kunalspathak approved these changes

Assignees

@EgorBo EgorBo

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EgorBo @kunalspathak