SHA3 #84132
Merged
SHA3 #84132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcsjones
added
NO-MERGE
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones Issue DetailsNot ready for review or API approved. Giving this a run through CI.
|
This was referenced Mar 30, 2023
stephentoub
reviewed
May 19, 2023
...braries/System.Security.Cryptography.Pkcs/src/System/Security/Cryptography/Pkcs/CmsSigner.cs
Show resolved
Hide resolved
stephentoub
reviewed
May 19, 2023
src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/SHA3_384.cs
Show resolved
Hide resolved
stephentoub
reviewed
May 19, 2023
src/libraries/Common/src/System/Security/Cryptography/HashOneShotHelpers.cs
Show resolved
Hide resolved
stephentoub
reviewed
May 19, 2023
src/libraries/Common/src/System/Security/Cryptography/HashOneShotHelpers.cs
Show resolved
Hide resolved
stephentoub
approved these changes
May 19, 2023
3 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
/azp run runtime-ioslike, runtime-android |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Test failures appear unrelated to me. I believe this is in a re-reviewable or mergable state. |
bartonjs
approved these changes
Jun 1, 2023
bartonjs
added
the
cryptographic-docs-impact
IDisposable
added a commit
to IDisposable/dotnet-runtime
that referenced
this pull request
Jun 7, 2023
In PR dotnet#84132, the addition of SHA3 variants to the HashAlgorithmNames was incomplete, leaving out the explicit handling of the SHA3 variants from the two helper methods: - `ToUpper()` - Would just return the name **unchanged** (which is likely wrong as it would allow _sha3-256_ through instead of uppercasing to _SHA3-256_. That's probably wrong. - `ToAlgorithmName()` - Would return the `ToString()` on the supplied `hashAlgorithm` instance, which would be the classname of the argument `hashAlgorithm` (e.g. `"System.Security.Cryptography.SHA3_256"`). That would not match the expectation of `"SHA3-256"` based on the other instances. I am not sure how important these are, or if they should be wrapped in a `#if NET8_0_OR_GREATER` wrapper (only some of the new SHA3 stuff was wrapped in that PR)
|
@vcsjones: Thanks a lot for your work! Linked to: |
This was referenced Jun 15, 2023
Merged
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the following SHA3 APIs:
SHA3_256,SHA3_384,SHA3_512HMACSHA3_256,HMACSHA3_384,HMACSHA3_512HashAlgorithmName.SHA3_256,HashAlgorithmName.SHA3_384,HashAlgorithmName.SHA3_512RSAEncryptionPadding.OaepSHA3_256,RSAEncryptionPadding.OaepSHA3_384,RSAEncryptionPadding.OaepSHA3_512In addition, this lights up the use of SHA-3 in several places that accept a
HashAlgorithmName, such asRfc2898DeriveBytes,HKDF, andSP800108HmacCounterKdfSHAKE is not in this pull request. It will be a follow up.
Contributes to #20342