[release/7.0] [mono] Fix incorrect version comparison in loader #76698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* Compare version components in the correct order in assembly_names_compare_versions * Fixes #76664
github-actions
bot
requested review from
vargaz,
lambdageek and
thaystg
as code owners
vargaz
approved these changes
Oct 6, 2022
rbhanda
added
Servicing-approved
|
CI failures are:
Aside from that, it has been approved and signed off. Ready to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #76665 to release/7.0
/cc @lambdageek @uweigand
Customer Impact
When customer code is compiled against older assemblies, but newer versions are available at runtime, certain combinations of old vs new versions wlll be compared incorrectly and the runtime will refuse to load the newer assembly believing it to be older than the older assembly.
This affects all platforms that use Mono as the execution engine (iOS, Android, WebAssembly, s390x Linux).
Testing
Manual testing
Risk
Low. The underlying issue is an incorrect order of comparison of the 3rd and 4th component of an assembly version. In many cases the 4th component is 0, so it doesn't matter if it's compared before or after the 3rd component since it doesn't affect the final result.