[release/8.0-staging] [wasm] Suppress export name minification #102155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraf
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing |
pavelsavara
approved these changes
May 13, 2024
kg
approved these changes
May 13, 2024
maraf
added
Servicing-consider
|
Approved via email |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #96951 to release/8.0-staging
Customer Impact
Fixes customer reported issue #101629. It is a regression from .NET 7.
This fix ensures that wasm exports are not minified regardless of other emscripten flags.
It is a regression from .NET 7. The MSBuild property mentioned in the workaround has a default value for Release configuration that is important in AOT mode (meaning the user would have to add the value with condition to get the same behavior).
It is not related to SkiaSharp, but to use of Jiterpreter in combination with native build (AOT, referencing unmanaged code, changing emscripten parameters, etc).
Testing
Manual test.
Risk
Low.