Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read EnableWriteXorExecute from runtimeConfig #101490

Merged
merged 5 commits into from
Apr 29, 2024
Merged

Read EnableWriteXorExecute from runtimeConfig #101490

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c3aaea2
Read System.Runtime.EnableWriteXorExecute from config.
Quickern Apr 20, 2024
70036f8
Merge branch 'main' into read-EnableWXorX-from-config
mangod9 Apr 24, 2024
b6857a1
Fixed default value for W^X enabling option.
Quickern Apr 24, 2024
fee9748
Revert "Fixed default value for W^X enabling option."
Quickern Apr 24, 2024
31f62a2
Merge branch 'main' into read-EnableWXorX-from-config
Quickern Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/coreclr/utilcode/executableallocator.cpp
View file
Open in desktop
Expand Up @@ -3,6 +3,7 @@

#include "pedecoder.h"
#include "executableallocator.h"
#include <configuration.h>

#if USE_LAZY_PREFERRED_RANGE
// Preferred region to allocate the code in.
Expand Down Expand Up @@ -260,7 +261,7 @@ HRESULT ExecutableAllocator::StaticInitialize(FatalErrorHandler fatalErrorHandle
#endif

g_fatalErrorHandler = fatalErrorHandler;
g_isWXorXEnabled = CLRConfig::GetConfigValue(CLRConfig::EXTERNAL_EnableWriteXorExecute) != 0;
g_isWXorXEnabled = Configuration::GetKnobBooleanValue(W("System.Runtime.EnableWriteXorExecute"), CLRConfig::EXTERNAL_EnableWriteXorExecute);
Quickern marked this conversation as resolved.
Show resolved Hide resolved
g_instance = new (nothrow) ExecutableAllocator();
if (g_instance == NULL)
{
Expand Down