Improved performance of CA1041

[NewellClark]

Fix #6143
I've reimplemented it as a syntax-node analyzer, as suggested.

[codecov]

Codecov Report

Merging #6671 (e1fbcc7) into main (2b6ab8d) will decrease coverage by 0.01%.
The diff coverage is 91.15%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6671      +/-   ##
==========================================
- Coverage   96.40%   96.39%   -0.01%     
==========================================
  Files        1379     1381       +2     
  Lines      322253   322340      +87     
  Branches    10460    10479      +19     
==========================================
+ Hits       310657   310730      +73     
- Misses       9103     9114      +11     
- Partials     2493     2496       +3     

[Youssef1313]

as suggested

This alone isn't really sufficient. it was mostly a "hypothesis". Profiling is really needed in real-world scenarios.

[Youssef1313]

This might crash for AliasQualifiedNameSyntax or GenericNameSyntax

[mavasani]

@NewellClark - thank you for putting the efforts here and creating this PR, it is much appreciated.
However, I believe we need to root cause the performance issue before taking this path. We definitely want analyzer authors to be able to write performant IOperation analyzers when analyzing executable code. I have added a comment in the original issue to help us move forward with the performance investigations.

[sharwell]

💡 We should now be able to use IAttributeOperation for this.

[Youssef1313]

💡 We should now be able to use IAttributeOperation for this.

This might not work for local functions I think (assuming the original implementation works for local functions)

[sharwell]

I would expect it to work for local functions?

[Youssef1313]

I would expect it to work for local functions?

@sharwell context.ContainingSymbol will return regular method, IIRC. Unless something has changed since I last looked?

[sharwell]

@Youssef1313 it seems like that would not be problematic. The handling will differ slightly for different contexts where this can occur, but in all cases it should be workable.