Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge AsyncRx.NET assemblies #1896

Merged
merged 4 commits into from
Mar 17, 2023
Merged

Merge AsyncRx.NET assemblies #1896

merged 4 commits into from
Mar 17, 2023

Conversation

idg10
Copy link
Collaborator

@idg10 idg10 commented Mar 15, 2023

Resolves #1891

System.Reactive.Async.Concurrency, System.Reactive.Async.Core, System.Reactive.Async.Disposables, System.Reactive.Async.Interfaces, System.Reactive.Async.Linq and System.Reactive.Async.Bcl all merged into System.Reactive.Async

System.Reactive.Shared has been removed because almost everything it did was already in System.Reactive. So we now take a dependency on System.Reactive, and one extension method puts back the one thing that was missing.

System.Reactive.Async.Concurrency, System.Reactive.Async.Core, System.Reactive.Async.Disposables, System.Reactive.Async.Linq and System.Reactive.Async.Bcl all merged into System.Reactive.Async

TBD: not sure what to do with System.Reactive.Async.Interfaces and System.Reactive.Shared yet
@idg10 idg10 self-assigned this Mar 15, 2023
All the types in that library are also defined in System.Reactive.

This meant we needed to change the name of our AsyncLock because System.Reactive also defines a type with that name, but it works differently.

(Also fixed erroneous paths for all the .tt files)
Replace System.Reactive.Shared with a reference to the System.Reactive NuGet package, and an extension method to supply the one extra feature AsyncRx.NET requires of Notification<T>.
@idg10 idg10 marked this pull request as ready for review March 16, 2023 10:57
@idg10 idg10 merged commit 1eda704 into main Mar 17, 2023
@idg10 idg10 deleted the feature/asyncrx-fewer-assemblies branch March 17, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce the number of AsyncRx.NET NuGet packages
2 participants