-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace xUnit with mstest #1883
Merged
Merged
Commits on Mar 6, 2023
-
xUnit is no longer able to run tests on UWP. MSTest supports this in Visual Studio 2022, so we are moving back to MSTest. (Rx used to used MSTest before, so this was a relatively straightforward change.)
Configuration menu - View commit details
-
Copy full SHA for 7d35de5 - Browse repository at this point
Copy the full SHA 7d35de5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2c2a78 - Browse repository at this point
Copy the full SHA b2c2a78View commit details
Commits on Mar 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e615448 - Browse repository at this point
Copy the full SHA e615448View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19c220b - Browse repository at this point
Copy the full SHA 19c220bView commit details
Commits on Mar 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b1ef387 - Browse repository at this point
Copy the full SHA b1ef387View commit details -
Revert last SynchronizationContext changes and ignore tests
Apparently supplying a SynchronizationContext isn't enough to prevent the EventLoop_ScheduleActionNested and EventLoop_ScheduleActionDue tests from hanging on the build agent. We'll need to fix this properly, so #1885 will track this
Configuration menu - View commit details
-
Copy full SHA for ca8e1aa - Browse repository at this point
Copy the full SHA ca8e1aaView commit details
Commits on Mar 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f53b50f - Browse repository at this point
Copy the full SHA f53b50fView commit details
Commits on Mar 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0f96e71 - Browse repository at this point
Copy the full SHA 0f96e71View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b2cace - Browse repository at this point
Copy the full SHA 9b2caceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 68e590d - Browse repository at this point
Copy the full SHA 68e590dView commit details
Commits on Mar 29, 2023
-
Fix race condition in CreateAsyncTest Make TaskLikeSupportTests run both with and without SynchronizationContext Revert the -v n option for test - hoping we now won't need it, now that we've configured test timeouts
Configuration menu - View commit details
-
Copy full SHA for 385da40 - Browse repository at this point
Copy the full SHA 385da40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e63631 - Browse repository at this point
Copy the full SHA 5e63631View commit details -
Change test filter to match docs
We had --filter "SkipCI!=true" but according to the docs, what we want is --filter "TestCategory!=SkipCI"
Configuration menu - View commit details
-
Copy full SHA for 32148a5 - Browse repository at this point
Copy the full SHA 32148a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04c663f - Browse repository at this point
Copy the full SHA 04c663fView commit details
Commits on Mar 30, 2023
-
Update remaining xUnit libraries
We're still using xUnit's assertions. And we're also still using xUnit in the test project that verifies that the API surface area didn't change. The newer API generator libraries have fixed some bugs - the 'verified' versions of these files used to have some missing type arguments. Any params argument using a generic type would just have an empty <>. Also, handling of the System.AttributeTargets looks like it used to be broken. The various .verified.cs files representing the expected API surface area have been modified so that they no longer have to work around these issues. Unfortunately xunit.assert.source appears to have a bug causing it to inject a public type, so we've had to work around that.
Configuration menu - View commit details
-
Copy full SHA for 5bd9df4 - Browse repository at this point
Copy the full SHA 5bd9df4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 370a05f - Browse repository at this point
Copy the full SHA 370a05fView commit details -
Reinstate some tests that the UWP runner was missing
Disable the handful of these that can't be expected to work on the current UWP implementation
Configuration menu - View commit details
-
Copy full SHA for 19ce448 - Browse repository at this point
Copy the full SHA 19ce448View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9dba05 - Browse repository at this point
Copy the full SHA b9dba05View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff43460 - Browse repository at this point
Copy the full SHA ff43460View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.