Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace xUnit with mstest #1883

Merged
merged 19 commits into from
Mar 30, 2023
Merged

Replace xUnit with mstest #1883

merged 19 commits into from
Mar 30, 2023

Commits on Mar 6, 2023

  1. Replace xUnit with mstest

    xUnit is no longer able to run tests on UWP. MSTest supports this in
    Visual Studio 2022, so we are moving back to MSTest. (Rx used to used
    MSTest before, so this was a relatively straightforward change.)
    idg10 committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    7d35de5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b2c2a78 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. Reinstate LicenseHeaderTest

    idg10 committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    e615448 View commit details
    Browse the repository at this point in the history
  2. Reinstate more disabled tests

    idg10 committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    19c220b View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Configuration menu
    Copy the full SHA
    b1ef387 View commit details
    Browse the repository at this point in the history
  2. Revert last SynchronizationContext changes and ignore tests

    Apparently supplying a SynchronizationContext isn't enough to prevent the EventLoop_ScheduleActionNested and EventLoop_ScheduleActionDue tests from hanging on the build agent.
    
    We'll need to fix this properly, so #1885 will track this
    idg10 committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    ca8e1aa View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. Configuration menu
    Copy the full SHA
    f53b50f View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Configuration menu
    Copy the full SHA
    0f96e71 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9b2cace View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    68e590d View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Add timeouts to test config

    Fix race condition in CreateAsyncTest
    
    Make TaskLikeSupportTests run both with and without SynchronizationContext
    
    Revert the -v n option for test - hoping we now won't need it, now that we've configured test timeouts
    idg10 committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    385da40 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5e63631 View commit details
    Browse the repository at this point in the history
  3. Change test filter to match docs

    We had --filter "SkipCI!=true" but according to the docs, what we want is --filter "TestCategory!=SkipCI"
    idg10 committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    32148a5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    04c663f View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Update remaining xUnit libraries

    We're still using xUnit's assertions. And we're also still using xUnit in the test project that verifies that the API surface area didn't change.
    
    The newer API generator libraries have fixed some bugs - the 'verified' versions of these files used to have some missing type arguments. Any params argument using a generic type would just have an empty <>. Also, handling of the System.AttributeTargets looks like it used to be broken. The various .verified.cs files representing the expected API surface area have been modified so that they no longer have to work around these issues.
    
    Unfortunately xunit.assert.source appears to have a bug causing it to inject a public type, so we've had to work around that.
    idg10 committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    5bd9df4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    370a05f View commit details
    Browse the repository at this point in the history
  3. Reinstate some tests that the UWP runner was missing

    Disable the handful of these that can't be expected to work on the current UWP implementation
    idg10 committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    19ce448 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b9dba05 View commit details
    Browse the repository at this point in the history
  5. Fix that last comment AGAIN

    idg10 committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    ff43460 View commit details
    Browse the repository at this point in the history