Remove Microsoft.Net.Compilers.Toolset #9329
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've had a reference to this package for a long time even though it is only meant to be used to pick up hotfixes to the compiler before they make their way into an SDK update. We're not using it for that purpose; in general, moving to a new version of the SDK is the supported way of picking up a newer version of the compiler. And since we're not controlling the SDK version (we just use whatever is on the machine) we can't even guarantee that the package is in fact giving us a newer version. Here we remove the package entirely. This also exposes that there was some sort of issue running the PublicAPI analyzer on our VB projects when using the Microsoft.Net.Compilers.Toolset package, and the PublicAPI.Shipped.txt files have been updated with the correct contents.
|
Can we please discuss this as a team at some point this week before merging? I'm not sure I'm a fan of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had a reference to this package for a long time even though it is only meant to be used to pick up hotfixes to the compiler before they make their way into an SDK update. We're not using it for that purpose; in general, moving to a new version of the SDK is the supported way of picking up a newer version of the compiler. And since we're not controlling the SDK version (we just use whatever is on the machine) we can't even guarantee that the package is in fact giving us a newer version.
Here we remove the package entirely. This also exposes that there was some sort of issue running the PublicAPI analyzer on our VB projects when using the Microsoft.Net.Compilers.Toolset package, and the PublicAPI.Shipped.txt files have been updated with the correct contents.
Microsoft Reviewers: Open in CodeFlow