Identify F# single case discriminated unions as SumType #8739
+102
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree company="NRK" |
ReubenBond
reviewed
Nov 30, 2023
| else if (baseType.GetAttributes(compilationAttributeType, out compilationAttributes) && compilationAttributes.Length > 0) | ||
| { | ||
| sumTypeCandidate = baseType; | ||
| } |
There was a problem hiding this comment.
Do we ever need to worry about deeper inheritance chains than this?
There was a problem hiding this comment.
Not that I know of. There is however an issue with DUs of 4 cases or more, but not due to inheritance. I will open separate issue for that.
ReubenBond
approved these changes
Nov 30, 2023
Single case discriminated unions do not inherit from an abstract base class, thus, for single case discriminated unions we need to look for the CompilationMappingAttribute on the type itself. Fix 8715
ReubenBond
pushed a commit
to ReubenBond/orleans
that referenced
this pull request
Dec 2, 2023
Single case discriminated unions do not inherit from an abstract base class, thus, for single case discriminated unions we need to look for the CompilationMappingAttribute on the type itself. Fix 8715
ReubenBond
added a commit
that referenced
this pull request
Dec 2, 2023
Single case discriminated unions do not inherit from an abstract base class, thus, for single case discriminated unions we need to look for the CompilationMappingAttribute on the type itself. Fix 8715 Co-authored-by: Geir Fiksdal <geirfiks@gmail.com>
ReubenBond
added a commit
that referenced
this pull request
Dec 2, 2023
Single case discriminated unions do not inherit from an abstract base class, thus, for single case discriminated unions we need to look for the CompilationMappingAttribute on the type itself. Fix 8715 Co-authored-by: Geir Fiksdal <geirfiks@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike discriminated unions with more than two cases, single case discriminated unions do not inherit from an abstract base class, thus, for single case discriminated unions we need to look for the CompilationMappingAttribute on the type itself.
Single case discriminated unions do have a declared instance member named "Item", so the
FSharpUnionCaseTypeDescriptioncorrectly identifies this.Fixes #8715
Microsoft Reviewers: Open in CodeFlow