Update nullability on IGrainDirectory and implementers. #8570
+33
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 14, 2023 10:06
Not sure if register should be able to return a null but that's currently what it could do in a bad case so currently reflecting that.
Not sure how the ILocalGrainDirectory plays into this since its a different interface.
Romanx
force-pushed
the
feature/grain-directory-nullability
branch
from
a5827c6 to
8f1a948
Compare
ReubenBond
approved these changes
Aug 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that during #7692 the nullable pragma was added to
IGrainDirectorywhich now had incorrect semantics exposed.I updated the obvious implementers of this interface to what I hope is the correct nullable values.
I wasn't sure how
ILocalGrainDirectoryplays into this since it doesn't implement the interface and so wanted to open a PR to start a conversation over it.Microsoft Reviewers: Open in CodeFlow