Optimize exclude computation on ItemGroupIntrinsicTask target call #9047
+48
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuliiaKovalova
changed the title
ladipro
approved these changes
Jul 19, 2023
src/Build/BackEnd/Components/RequestBuilder/IntrinsicTasks/ItemGroupIntrinsicTask.cs
Show resolved
Hide resolved
ladipro
reviewed
Jul 19, 2023
Co-authored-by: Ladi Prosek <ladi.prosek@gmail.com>
maridematte
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8984
Context
When glob expansion runs in a target via ItemGroupIntrinsicTask, it implicitly invokes
EngineFileUtilities.GetFileListEscapedfor Excludes evaluation.Changes Made
Traverse Exclude only if EngineFileUtilities.GetFileListEscaped wasn't called in order to avoid double traversal.
Testing
Existing cases cover this change.