Revert "ResolveAssemblyReference CPU optimizations (#8916)" #9037
+38
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1ff019a.
ladipro
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
So far I know the problem is in 1ff019a#diff-20c3f77300d596d35264f7f9351652e233cb3455c3f7a7262df4842d437fe8efR1407-R1414 but let's revert for now to unblock insertions. Thank you!
JanKrivanek
approved these changes
Jul 14, 2023
|
Uh-oh, the problem is that the task item implementing |
ladipro
added a commit
to ladipro/msbuild
that referenced
this pull request
Jul 17, 2023
…)" (dotnet#9037)" This reverts commit 4989625.
|
#9044 has the fix. I have tested it with an experimental VS insertion. |
YuliiaKovalova
pushed a commit
to YuliiaKovalova/msbuild
that referenced
this pull request
Jul 18, 2023
…tnet#9037) This reverts commit 1ff019a. Fixes # VS Insertion, C++ Project System - PR: VC.ProjectSystem.VCProject.CachedProjectAutomation fails since these changes. https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_git/VS/pullRequest/483186#1689247828 So far I know the problem is in 1ff019a#diff-20c3f77300d596d35264f7f9351652e233cb3455c3f7a7262df4842d437fe8efR1407-R1414 but let's revert for now to unblock insertions. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1ff019a.
Fixes #
VS Insertion, C++ Project System - PR: VC.ProjectSystem.VCProject.CachedProjectAutomation fails since these changes.
https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_git/VS/pullRequest/483186#1689247828