Fix TaskRegistry mutability #9032
Merged
+200
−153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainersigwald
approved these changes
Jul 13, 2023
JanKrivanek
force-pushed
the
proto/TaskRegistryMutability
branch
from
7825043 to
50eebae
Compare
rokonec
reviewed
Jul 14, 2023
rokonec
reviewed
Jul 14, 2023
rokonec
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ADO#1801351 and ADO#1801341
Reuses chunk of changes from #8861
Context
TaskRegistry should be logically immutable after initialization and sharing is possible and ok, but there can be actual writes on first access which needs to be made thread safe
Changes Made
ProjectImportPathMatchandToolSetadjustment to better express immutabilityTesting
Existing unit tests