Fix /warnaserror false positive overall success #8953
Merged
+2
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
where submission is considered to be done and assumed its final state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8735, possibly #5689, #2845
Context
There were race condition when
ProjectFinishedlog message has been processed afterBuildResultevent. Even thoughProjectFinishedlog message event is always send beforeBuildResultevent from Node, becauseProjectFinishedis asyncronously routed byLoggingServicereversing order can and do often happen.Changes Made
Updating
_overallBuildSuccessin one place when submission is considered to be done and assumed its final state.Testing
Can't local repro.