Expose static methods from System.OperatingSystem #8935
Merged
+414
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoeplinger
reviewed
Jun 22, 2023
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
akoeplinger
reviewed
Jun 22, 2023
akoeplinger
approved these changes
Jun 26, 2023
akoeplinger
approved these changes
Jun 27, 2023
This reverts commit 759ae6a.
akoeplinger
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5982
Context
Expose methods added in .Net 5.0. Create alternate stand-in for net471.
Changes Made
Microsoft.Build.Framework.OperatingSystemas stand-in substitute for net471. The class assumes that only Windows is supported.Microsoft.Build.Framework.OperatingSystem.System.OperatingSystemor fromMicrosoft.Build.Framework.OperatingSystem.IsOSPlatformproperty functionTesting
Tested on windows 11 and macOS 12. tested by running full suite of unit test.
Notes