Prevent ObjectDisposedException in BuildManager #11122
Merged
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuliiaKovalova
approved these changes
Dec 10, 2024
|
it should resolve |
|
Btw. ideally we'd really dispose the event - but it's instantiated once per Graph build request. So let's rather prevent a crash leading to losing diagnostics info |
JanProvaznik
approved these changes
Dec 10, 2024
|
[surprised] Yuliia Kovalova reacted to your message:
…________________________________
From: Jan Provazník ***@***.***>
Sent: Tuesday, December 10, 2024 8:58:31 PM
To: dotnet/msbuild ***@***.***>
Cc: Yuliia Kovalova ***@***.***>; Comment ***@***.***>
Subject: Re: [dotnet/msbuild] Prevent ObjectDisposedException in BuildManager (PR #11122)
@JanProvaznik approved this pull request.
—
Reply to this email directly, view it on GitHub<#11122 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWYM53SQ5DOPXWBJPPW26BL2E5IXPAVCNFSM6AAAAABTL5YSQOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIOJTGU4TCMBTGY>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ObjectDisposedException occuring during investigation of #11091
Fixes #10753
Context
We were blindly disposing a handle in synchronous scope while asynchronous code could heve been still running.
During the errors during GraphBuild this can lead to unhandled exceptions and unfinished logs