Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update branding doc #11020

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Update branding doc #11020

merged 4 commits into from
Dec 10, 2024

Conversation

drewnoakes
Copy link
Member

A few minor changes:

  • Removed statement that the logo was designed by Immo (sorry Immo!).
  • Added pixel dimensions of images.
  • Moved images out of headings, as they looked like they belonged to the previous section.

@drewnoakes drewnoakes added the Documentation Issues about docs, including errors and areas we should extend (this repo and learn.microsoft.com) label Nov 22, 2024
@drewnoakes
Copy link
Member Author

On the NuGet icon, the docs suggest an image size of 128x128px. From https://learn.microsoft.com/en-us/nuget/reference/nuspec#icon:

Image file size is limited to 1 MB. Supported file formats include JPEG and PNG. We recommend an image resolution of 128x128.

Also, is there an SVG version of the logo that can be added here?

@YuliiaKovalova
Copy link
Member

On the NuGet icon, the docs suggest an image size of 128x128px. From https://learn.microsoft.com/en-us/nuget/reference/nuspec#icon:

Image file size is limited to 1 MB. Supported file formats include JPEG and PNG. We recommend an image resolution of 128x128.

Also, is there an SVG version of the logo that can be added here?

Hi Drew,

We don't have 128x128, only 64x64 or 256x256
and no svg format in the initial set. Is it necessary to request these pics?

@drewnoakes
Copy link
Member Author

Is it necessary to request these pics?

I would definitely ask the design team for a vector-based version of the logo, and add it here. SVG is great, but AI/PDF are fine too.

A vector-based version of the logo can be used in more places. For example, to print stickers/posters with the logo, you'd want much higher resolution, and vectors can scale to any size. It'd allow us to produce the 128x128px version ourselves.

@YuliiaKovalova
Copy link
Member

Hi @drewnoakes ,

I have requested these images from designers team. I will get back to you once they are ready.

@YuliiaKovalova
Copy link
Member

A few minor changes:

- Removed statement that the logo was designed by Immo (sorry Immo!).
- Added pixel dimensions of images.
- Moved images out of headings, as they looked like they belonged to the previous section.
This is the recommended size for NuGet package icons.
@drewnoakes drewnoakes force-pushed the drewnoakes/branding-doc branch from 125ab30 to 9a7c128 Compare December 3, 2024 02:50
@drewnoakes
Copy link
Member Author

Thanks @YuliiaKovalova. I've included the SVG file and changed the NuGet icon to the 128x128px version.

Also optimized the PNG files a little:

image

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@drewnoakes drewnoakes force-pushed the drewnoakes/branding-doc branch from 9a7c128 to 1918864 Compare December 3, 2024 02:55
Copy link
Member

@YuliiaKovalova YuliiaKovalova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@maridematte maridematte merged commit 82c8f93 into main Dec 10, 2024
10 checks passed
@maridematte maridematte deleted the drewnoakes/branding-doc branch December 10, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues about docs, including errors and areas we should extend (this repo and learn.microsoft.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants