Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register Microsoft.VisualStudio.SolutionPersistence for VS #10843

Merged

Conversation

YuliiaKovalova
Copy link
Member

Fixes #
VS insertion fails with invalid assembly count
https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_git/VS/pullRequest/585993#1729185437

It must be attributed to adding Microsoft.VisualStudio.SolutionPersistence in scope of slnx PR: https://github.com/dotnet/msbuild/pull/10794/files#diff-52cc55d60d91e826b8fe4b773f4ee868a6e1cd76f6da82771841395fe8a9c0ef

Solution

add registration for Microsoft.VisualStudio.SolutionPersistence.dll

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only blocking issue is the pkgdef one, go ahead otherwise.

YuliiaKovalova and others added 2 commits October 18, 2024 16:03
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
@YuliiaKovalova YuliiaKovalova merged commit b93bec0 into dotnet:main Oct 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants