[HybridWebView] Always complete web requests #28286
Merged
+9
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR ensures that all web requests in HybridWebView complete regardless of success, preventing stalls in asynchronous JS operations. Key changes include:
- Adding HybridWebView developer tools in debug builds in MauiProgramDefaults.
- Updating the iOS HybridWebViewHandler to always return a 404 response with a consistent message when requests fail, eliminating early exits.
- Removing the conditional error logging branch in StartUrlSchemeTask to guarantee request completion.
Reviewed Changes
| File | Description |
|---|---|
| src/Core/tests/DeviceTests.Shared/MauiProgramDefaults.cs | Added registration of developer tools in debug builds to support HybridWebView functionality. |
| src/Core/src/Handlers/HybridWebView/HybridWebViewHandler.iOS.cs | Modified response handling to always complete web requests using a lazy 404 message and removed error logging branch. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/Core/src/Handlers/HybridWebView/HybridWebViewHandler.iOS.cs:155
- Ensure there are automated tests covering the new behavior for non-200 responses in HybridWebViewHandler.iOS.cs. Verify that TestCases.HostApp and TestCases.Shared.Tests include cases that validate the consistent completion of web requests.
if (statusCode == 200)
tj-devel709
approved these changes
Mar 10, 2025
rmarinho
approved these changes
Mar 11, 2025
|
/backport release/9.0.1xx-sr4 |
|
/backport to release/9.0.1xx-sr4 |
|
Started backporting to release/9.0.1xx-sr4: https://github.com/dotnet/maui/actions/runs/13790493864 |
rmarinho
pushed a commit
that referenced
this pull request
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Currently iOS and Mac Catalyst only complete the requests if they are successful. This PR updates the logic to make sure to always complete the requests so the app can continue. Any async fetches will now complete, allowing the JS to continue.
Windows and Android already do this and I added a test for this in #28230, however Mac Catalyst was very iffy and we merged thinking it was the CI ghosts. Turns out, CI was sending the right messages and we trusted AI too much.
Issues Fixed
Fixes #28285