Add attempt number to failed builds #28280
Merged
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR updates the artifact publishing steps in the device tests pipeline to distinguish between succeeded and failed builds by incorporating an attempt number into the failed build artifact name.
- Updates the succeeded build publish step to only run on successful builds.
- Adds a new publish step for failed builds that appends the System.JobAttempt value.
Reviewed Changes
| File | Description |
|---|---|
| eng/pipelines/common/device-tests-steps.yml | Modified publish steps to handle artifacts for succeeded and failed builds separately. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
| artifact: ${{ parameters.appArtifactName }} | ||
| - publish: ${{ parameters.checkoutDirectory }}/artifacts/bin |
There was a problem hiding this comment.
The new publish step for failed artifacts has inconsistent indentation compared to the surrounding steps. Align its indentation with the existing publish steps to ensure correct YAML parsing.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
PureWeen
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Builds will fail, so make sure they have an attempt number in the name