-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[android] add AOT profile for dotnet new maui -sc
#28172
Merged
Merged
+10,188
−204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a new "sample content" switch for the `dotnet new maui` template that brings in various NuGets and things automatically. None of these things are in the built-in AOT profile, so let's record one specifically for this template. I also updated the other AOT profiles, as I can see some of the latest changes in dotnet/main/main calls different methods on startup. Testing an average of 10 runs on a Pixel 7 Pro: $ dotnet new maui Before: Average(ms): 446 Std Err(ms): 2.28035085019828 Std Dev(ms): 7.21110255092798 After: Average(ms): 441 Std Err(ms): 5.09901951359278 Std Dev(ms): 16.1245154965971 $ dotnet new maui -sc Before: Average(ms): 1073.6 Std Err(ms): 8.35623519694525 Std Dev(ms): 26.4247358864127 After: Average(ms): 832.1 Std Err(ms): 5.65773806392625 Std Dev(ms): 17.8913386866383 Since `dotnet new maui -sc` is still a bit slower, I will investigate how to improve this in other PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR introduces a new AOT profile for the "sample content" switch in the dotnet new maui template and updates existing profiles to reflect recent startup method changes in dotnet/main.
- Adds build instructions and AOT profile for the maui-sc (sample content) template
- Updates build commands and related documentation in the README to use the new ./.dotnet/dotnet path
Reviewed Changes
File | Description |
---|---|
src/ProfiledAot/README.md | Updated build instructions and added details for the maui-sc profile |
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
mattleibow
approved these changes
Mar 5, 2025
bhavanesh2001
pushed a commit
to bhavanesh2001/maui
that referenced
this pull request
Mar 7, 2025
There is a new "sample content" switch for the `dotnet new maui` template that brings in various NuGets and things automatically. None of these things are in the built-in AOT profile, so let's record one specifically for this template. I also updated the other AOT profiles, as I can see some of the latest changes in dotnet/main/main calls different methods on startup. Testing an average of 10 runs on a Pixel 7 Pro: $ dotnet new maui Before: Average(ms): 446 Std Err(ms): 2.28035085019828 Std Dev(ms): 7.21110255092798 After: Average(ms): 441 Std Err(ms): 5.09901951359278 Std Dev(ms): 16.1245154965971 $ dotnet new maui -sc Before: Average(ms): 1073.6 Std Err(ms): 8.35623519694525 Std Dev(ms): 26.4247358864127 After: Average(ms): 832.1 Std Err(ms): 5.65773806392625 Std Dev(ms): 17.8913386866383 Since `dotnet new maui -sc` is still a bit slower, I will investigate how to improve this in other PRs.
rmarinho
pushed a commit
that referenced
this pull request
Mar 11, 2025
There is a new "sample content" switch for the `dotnet new maui` template that brings in various NuGets and things automatically. None of these things are in the built-in AOT profile, so let's record one specifically for this template. I also updated the other AOT profiles, as I can see some of the latest changes in dotnet/main/main calls different methods on startup. Testing an average of 10 runs on a Pixel 7 Pro: $ dotnet new maui Before: Average(ms): 446 Std Err(ms): 2.28035085019828 Std Dev(ms): 7.21110255092798 After: Average(ms): 441 Std Err(ms): 5.09901951359278 Std Dev(ms): 16.1245154965971 $ dotnet new maui -sc Before: Average(ms): 1073.6 Std Err(ms): 8.35623519694525 Std Dev(ms): 26.4247358864127 After: Average(ms): 832.1 Std Err(ms): 5.65773806392625 Std Dev(ms): 17.8913386866383 Since `dotnet new maui -sc` is still a bit slower, I will investigate how to improve this in other PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
delighter
platform/android 🤖
t/perf
The issue affects performance (runtime speed, memory usage, startup time, etc.) (sub: perf)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a new "sample content" switch for the
dotnet new maui
template that brings in various NuGets and things automatically.None of these things are in the built-in AOT profile, so let's record one specifically for this template. I also updated the other AOT profiles, as I can see some of the latest changes in dotnet/main/main calls different methods on startup.
Testing an average of 10 runs on a Pixel 7 Pro:
Since
dotnet new maui -sc
is still a bit slower, I will investigate how to improve this in other PRs.