[Testing] Fix for flaky UITests in CI that occasionally fail - 4 #28137
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @HarishKumarSF4517! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
There was a problem hiding this comment.
PR Overview
This PR aims to improve the reliability of UI tests in CI by adjusting the scrolling interactions in two test cases. Key changes include:
- Replacing a ScrollUp action with a DragCoordinates gesture in Issue16910 to ensure consistent triggering of the refresh command.
- Adding a preliminary ScrollUp step before a ScrollDown in Issue25889 to reliably trigger the command.
Reviewed Changes
| File | Description |
|---|---|
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16910.cs | Modified the refresh test to use DragCoordinates with computed element positions. |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25889.cs | Adjusted scrolling sequence by adding a ScrollUp before ScrollDown with an updated comment. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25889.cs
Outdated
Show resolved
Hide resolved
HarishKumarSF4517
force-pushed
the
enable-xamarinuitest-harish38
branch
from
4917bc2 to
d6d7495
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Mar 3, 2025
jsuarezruiz
approved these changes
Mar 4, 2025
|
/rebase |
|
LGTM, but rebased to fix the flaky tests already fixed by #28137 and failing in the latest build from this PR. |
…889.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
github-actions
bot
force-pushed
the
enable-xamarinuitest-harish38
branch
from
d6d7495 to
531c26c
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jfversluis
approved these changes
Mar 5, 2025
bhavanesh2001
pushed a commit
to bhavanesh2001/maui
that referenced
this pull request
Mar 7, 2025
…net#28137) * Increase stability for CI failure Issues * Update src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25889.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This pull request includes updates to the test cases in the
src/Controls/tests/TestCases.Shared.Tests/Tests/Issuesdirectory to improve the reliability of UI interactions during automated testing. The most important changes involve replacing certain Appium actions with more reliable alternatives and adding comments to explain these changes.src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16910.cs: ReplacedApp.ScrollUpwithApp.DragCoordinatesin theBindingUpdatesFromInteractiveRefreshmethod to ensure the refresh command is triggered consistently in CI environments.src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25889.cs: Added a step to scroll up before scrolling down in theRemainingItemsThresholdReachedCommandFiredmethod to ensure the command is triggered reliably in CI environments.TestCases
Fixes #28178