[Testing] Enabling more UI Tests by removing platform specific condition - 16 #27968
Conversation
dotnet-policy-service
bot
added
community ✨
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (6)
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue2617.cs:22
- Using Thread.Sleep instead of an asynchronous delay (e.g. Task.Delay) can block the UI thread in tests. Consider retaining an async pattern so the test remains responsive and reliable.
Thread.Sleep(5000);
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue1799.cs:31
- Removal of the iOS-specific conditional compilation guard may result in iOS-specific test code running on non-iOS platforms and causing unexpected failures.
#endif
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue1900.cs:23
- The removal of the iOS conditional compilation guard may enable platform-specific tests on non-iOS platforms, potentially triggering failures when iOS-only APIs are used.
#endif
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue7313.cs:24
- Removing the iOS conditional compilation guard may cause tests that rely on iOS-specific behavior to run on unsupported platforms, leading to unexpected outcomes.
#endif
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25724.cs:1
- The new conditional compilation directive in Issue25724 targets a different set of platforms compared to the original iOS/MacCatalyst condition; please verify that tests are executed only on the intended platforms.
#if TEST_FAILS_ON_ANDROID && TEST_FAILS_ON_WINDOWS
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue5354.cs:1
- The composite conditional flags in Issue5354 should be reviewed to ensure that tests are correctly disabled on the intended platforms; unexpected combinations may lead to tests running in unsupported environments.
#if TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_IOS && TEST_FAILS_ON_WINDOWS
| @@ -43,7 +43,7 @@ protected override void Init() | |||
| nameLabel.SetBinding(Label.TextProperty, new Binding(".")); | |||
| var cell = new ViewCell | |||
| { | |||
| View = new Frame() | |||
| View = new Border() | |||
There was a problem hiding this comment.
Replacing Frame with Border might change layout or styling behavior; please verify that this change aligns with the intended UI design and that corresponding documentation in the public docs is updated if needed.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| @@ -1,5 +1,4 @@ | |||
| #if IOS | |||
| using NUnit.Framework; | |||
| using NUnit.Framework; | |||
There was a problem hiding this comment.
This one failed on Windows on CI, but pass locally. I'm just sharing this but I think it could just be a one-time problem and pass with a retry.
There was a problem hiding this comment.
@jsuarezruiz Yes, seems test is consistently failing in the CI environment, but I cannot reproduce the issue locally. I'm adding a failure condition for Windows to maintain CI stability. Please review and let me know if you have any concerns.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
TamilarasanSF4853
force-pushed
the
enabled-platform-specific-testcases
branch
from
364fc74 to
9562aaf
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
enabled-platform-specific-testcases
branch
from
f45b269 to
3980ff9
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
…ion - 16 (dotnet#27968) * enable the test case for all platform * comment modification * comment modification * comment modification * added images * added snapshot * updated the changes * code changes
…ion - 16 (#27968) * enable the test case for all platform * comment modification * comment modification * comment modification * added images * added snapshot * updated the changes * code changes
Description of Change
The tests, previously added for specific platforms alone, now we are reviewed, and enabled the tests in all applicable platforms with the Appium framework. We are going to enable tests in blocks in different PRs. This is the 16th group of tests enabled.
Test Cases:
Fixes #22902