Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Run tests verifying snapshots on mac now that's possible #27893

Merged
merged 3 commits into from
Feb 22, 2025

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

We did not have snapshot verification tests implemented in Catalyst until #25710. For that reason, using compilation directives, we did not run tests verifying snapshots on mac.
This PR adds changes to enable those tests on Mac.

Verified

This commit was signed with the committer’s verified signature.
Darksonn Alice Ryhl
@Copilot Copilot bot review requested due to automatic review settings February 19, 2025 08:31
@jsuarezruiz jsuarezruiz requested a review from a team as a code owner February 19, 2025 08:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue21368.cs: Evaluated as low risk
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue19338.cs: Evaluated as low risk

Verified

This commit was signed with the committer’s verified signature.
Darksonn Alice Ryhl
@jfversluis jfversluis merged commit d537ef1 into main Feb 22, 2025
123 checks passed
@jfversluis jfversluis deleted the more-snapshot-tests-mac branch February 22, 2025 10:30
jfversluis pushed a commit that referenced this pull request Feb 22, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…27893)

* Run tests verifying snapshots on mac now that's possible

* Added snapshots
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants