[Essentials] Longitude Validation #27784
Merged
+5
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubaflo
added
area-essentials
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
🚨 API change(s) detected @davidbritch FYI |
|
Not sure if anything about this is described in the docs. Technically a behavioral breaking change although I think it’s for the better. |
|
Agreed! Devs can easily implement the previous logic and it was confusing that latitude didn't work as longitude |
dartasen
reviewed
Feb 16, 2025
| while (Longitude <= -180) | ||
| Longitude += 360; | ||
| // check if longitude is in (-180, 180] | ||
| if (Math.Abs(latitude) > 180) |
There was a problem hiding this comment.
@kubaflo @jfversluis I feel like it's a wrong copy paste here, it should be longitude inside the Math.abs...
I guess it does describe that this area is lacking of unit tests
There was a problem hiding this comment.
You're absolutely right. I'm sorry about that. Here's the fix: #27834
@jfversluis could you please /azp
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Fixed
Fixes #27774