Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISO information to Locale API documentation #27746

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

jfversluis
Copy link
Member

Description of Change

Adds the ISO information in the API documentation so people know which standards are being used for the TTS Locale per platform.

Issues Fixed

Fixes dotnet/dotnet-maui-api-docs#114

@jfversluis jfversluis added the area-docs Conceptual docs, API docs, Samples label Feb 12, 2025
@Copilot Copilot bot review requested due to automatic review settings February 12, 2025 14:13
@jfversluis jfversluis requested a review from a team as a code owner February 12, 2025 14:13
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

src/Essentials/src/TextToSpeech/TextToSpeech.shared.cs:213

  • For iOS and Windows, this field is not used and is .
For iOS and Windows this field is not used and <see langword="null"/> .

/// <remarks>
/// <para>This value may vary between platforms.</para>
/// <para>
/// For Android this used the ISO 639 alpha-2 or alpha-3 language code, or registered language subtags up to 8 alpha letters (for future enhancements).
Copy link
Preview

Copilot AI Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Android, this uses the ISO 639 alpha-2 or alpha-3 language code, or registered language subtags up to 8 alpha letters (for future enhancements).

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.


/// <remarks>
/// <para>This value may vary between platforms.</para>
/// <para>For Android this used the ISO 3166 alpha-2 country code or UN M.49 numeric-3 area code.</para>
Copy link
Preview

Copilot AI Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Android, this uses the ISO 3166 alpha-2 country code or UN M.49 numeric-3 area code.

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

@rmarinho rmarinho merged commit 4a69bde into main Feb 12, 2025
76 of 125 checks passed
@rmarinho rmarinho deleted the add-isoinfo-locale branch February 12, 2025 19:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-docs Conceptual docs, API docs, Samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Iso standards
3 participants