Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Enabling more UI Tests by removing platform specific condition - 9 #27743

Merged

Conversation

HarishKumarSF4517
Copy link
Contributor

@HarishKumarSF4517 HarishKumarSF4517 commented Feb 12, 2025

Description of Change

The tests, previously added for specific platforms alone, now we are reviewed, and enabled the tests in all applicable platforms with the Appium framework.We are going to enable tests in blocks in different PRs. This is the 9th group of tests enabled.

Test Cases:

  • Issue23973
  • Issue25074
  • Issue25074_2
  • Issue25649
  • Issue25889

Fixes #22902

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Feb 12, 2025
Copy link
Contributor

Hey there @HarishKumarSF4517! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@HarishKumarSF4517 HarishKumarSF4517 changed the title [Testing] Enabling more UI Tests by removing platform specific condition - 8 [Testing] Enabling more UI Tests by removing platform specific condition - 9 Feb 12, 2025
@LogishaSelvarajSF4525 LogishaSelvarajSF4525 added area-testing Unit tests, device tests partner/syncfusion Issues / PR's with Syncfusion collaboration labels Feb 12, 2025
@@ -1,4 +1,4 @@
#if TEST_FAILS_ON_CATALYST // Scroll actions do not work on MacCatalyst, so this test is ignored on MacCatalyst.
// Scroll actions do not work on MacCatalyst, so this test is ignored on MacCatalyst.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still fails recently? In Catalyst, must use

driver.ExecuteScript("macos: scroll", new Dictionary<string, object>
using macos: scroll

Let me know to take a look.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jsuarezruiz ,
It works fine and now I have updated the changes

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@dotnet dotnet deleted a comment from HarishKumarSF4517 Feb 12, 2025
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HarishKumarSF4517 HarishKumarSF4517 marked this pull request as ready for review February 13, 2025 06:05
@HarishKumarSF4517 HarishKumarSF4517 requested a review from a team as a code owner February 13, 2025 06:05
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending snapshots on macOS:

ButtonTitleFillsSpaceWhenImageChanges
image

ButtonResizesWhenTitleOrImageChanges
image

@HarishKumarSF4517
Copy link
Contributor Author

Hi @jsuarezruiz ,
I have attached the Snapshots on macOS

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jfversluis
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz
jsuarezruiz previously approved these changes Feb 20, 2025
@jsuarezruiz jsuarezruiz requested a review from PureWeen February 21, 2025 11:59
Copy link
Member

@jfversluis jfversluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve conflicts please

@HarishKumarSF4517
Copy link
Contributor Author

Resolve conflicts please

HI @jfversluis ,
I have resolved the Conflicts.

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jfversluis jfversluis dismissed PureWeen’s stale review February 24, 2025 20:21

Feedback addressed

@jfversluis jfversluis merged commit 9e16a82 into dotnet:main Feb 24, 2025
123 checks passed
@jfversluis jfversluis added this to the .NET 9 SR5 milestone Feb 24, 2025
tj-devel709 pushed a commit that referenced this pull request Mar 3, 2025
…ion - 9 (#27743)

* Enabled TestCases in All platforms

* Updated changes

* Updated Snapshots

* Updated Mac Snapshots

* Update Issue25362.cs
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TEST] Review all (UI) Tests and remove platform-specific runs where possible
5 participants