[Testing] Migration of Compatibility.Core platform-specific unit tests into device tests - 1 #27695
+121
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandhan-rajagopal
added
the
partner/syncfusion
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- src/Controls/tests/DeviceTests/Elements/Editor/EditorTests.cs: Evaluated as low risk
- src/Controls/tests/DeviceTests/Elements/Label/LabelTests.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/Controls/tests/DeviceTests/Elements/Image/ImageTests.cs:81
- [nitpick] The test description should be more specific. Consider renaming to 'The BackgroundColor of an Image should match the native background color'.
[Description("The BackgroundColor of a Image should match with native background color")]
|
/azp run |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
github-actions
bot
force-pushed
the
UnitToDeviceTest-1
branch
from
b3a8027 to
3568ac1
Compare
|
/azp run |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
github-actions
bot
force-pushed
the
UnitToDeviceTest-1
branch
from
3568ac1 to
ff042da
Compare
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
because this test fails unable to get the current color.
github-actions
bot
force-pushed
the
UnitToDeviceTest-1
branch
from
ff042da to
ae456c3
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jfversluis
approved these changes
Feb 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Migration of Compatibility.Core platform-specific unit tests to device tests. Here the migrated cases which ensuring that the background color consistency of different elements matches their native counterparts. We are going to migrate tests in blocks in different PRs. This is the 1st group.
There are unit tests under:
That are not running right now. these cases from Xamarin.Forms where they could run as unit tests, but now with .NET MAUI this is not possible. So here I migrated the following cases in device tests.
Background Color Consistency Tests:
BoxViewBackgroundColorConsistentto verify that theBackgroundColorof aBoxViewmatches the native background color. (src/Controls/tests/DeviceTests/Elements/BoxView/BoxViewTests.cs)ButtonBackgroundColorConsistentto verify that theBackgroundColorof aButtonmatches the native background color. (src/Controls/tests/DeviceTests/Elements/Button/ButtonTests.cs)EditorBackgroundColorConsistentto verify that theBackgroundColorof anEditormatches the native background color. (src/Controls/tests/DeviceTests/Elements/Editor/EditorTests.cs)EntryBackgroundColorConsistentto verify that theBackgroundColorof anEntrymatches the native background color. (src/Controls/tests/DeviceTests/Elements/Entry/EntryTests.cs)ImageBackgroundColorConsistentto verify that theBackgroundColorof anImagematches the native background color. (src/Controls/tests/DeviceTests/Elements/Image/ImageTests.cs)LabelBackgroundColorConsistentto verify that theBackgroundColorof aLabelmatches the native background color. (src/Controls/tests/DeviceTests/Elements/Label/LabelTests.cs)PickerBackgroundColorConsistentto verify that theBackgroundColorof aPickermatches the native background color. (src/Controls/tests/DeviceTests/Elements/Picker/PickerTests.cs)Issues Fixed
Fixes #27303