[Testing, CI] Increased threshold value to make Resizetizer unit tests pass on arm64 machines #27684
Conversation
|
Hey there @anandhan-rajagopal! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
anandhan-rajagopal
added
partner/syncfusion
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| @@ -14,7 +14,7 @@ public class BaseTest : IDisposable | |||
| { | |||
| private const string TestFolderName = "Microsoft.Maui.Resizetizer.Tests"; | |||
| private const string TestImagesFolderName = "imageresults"; | |||
| private const double ImageErrorThreshold = 0.0027; | |||
| private const double ImageErrorThreshold = 0.27; | |||
There was a problem hiding this comment.
What do we think about this diff @mattleibow @BretJohnson ?
There was a problem hiding this comment.
@anandhan-rajagopal Could you share more details? Why required the change?
There was a problem hiding this comment.
@jsuarezruiz The issue has been reproduced on ARM-based operating systems, where the failures result from differences in image comparison, with a maximum threshold of 0.27 percent for each test. Each test fails due to image discrepancies at several values, so I selected the maximum difference observed, which appears to be related to edge pixel variations. Upon investigation, it seems that these differences are likely influenced by the screen resolution of the operating system.
|
Seems we have other tests failing now related with Skia cc @mattleibow |
@rmarinho Identical pixel-level variations in the image were observed, so a maximum threshold value of 0.07 was added for these tests. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run MAUI-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Description of Change
This pull request includes changes to update the architecture for macOS builds and adjust image error thresholds in unit tests. The most important changes are as follows:
Unit Test Adjustments:
src/SingleProject/Resizetizer/test/UnitTests/BaseTest.cs: Increased theImageErrorThresholdconstant from0.0027to0.27to allow for greater variance in image similarity tests.src/SingleProject/Resizetizer/test/UnitTests/BaseTest.cs: Modified theAssertFileMatchesRealmethod to use theImageErrorThresholdconstant when callingImageAssert.Equivalent.Issues Fixed
Fixes #26516