[Android] [Shell] Ensure AnimationFinished is called when app backgrounds mid-animation
#27534
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rounds mid-animation
albyrock87
added a commit
to nalu-development/maui-custom
that referenced
this pull request
Feb 3, 2025
|
Hey there @albyrock87! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
jsuarezruiz
added
area-animation
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
MartyIX
reviewed
Feb 3, 2025
| // the app enters background state in the middle of the animation causing the fragment to be destroyed without completing the animation. | ||
| // That'll cause `IAnimationListener.onAnimationEnd` to not be called, so we need to call it manually if something is still subscribed to the event | ||
| // to avoid the navigation `TaskCompletionSource` to be stuck forever. | ||
| AnimationFinished?.Invoke(this, EventArgs.Empty); |
There was a problem hiding this comment.
just wondering: Should this method be called only if _isAnimating == true?
There was a problem hiding this comment.
Good question! _isAnimating = true happens after AnimationFinished += subscription, so it's better to trust the event to avoid race conditions.
jsuarezruiz
approved these changes
Mar 4, 2025
bhavanesh2001
pushed a commit
to bhavanesh2001/maui
that referenced
this pull request
Mar 7, 2025
…rounds mid-animation (dotnet#27534)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Consider this shell stack:
ShellContent>InnerPage.The user presses a button to pop the page programmatically:
DoSomethingElseis never being called if the user presses the android back button quickly while the animation is still in progress.This is caused because
IAnimationListener.onAnimationEndis never being invoked by android as the animation was canceled.Description of Change
Trigger the animation complete even upon fragment
Destroyso that if the navigation is still waiting, it can complete.Issues Fixed
Relates to #26617 (#27364)