Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds very basic CSS support for Border #27529

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

sthewissen
Copy link
Contributor

@sthewissen sthewissen commented Feb 3, 2025

Description of Change

Added basic support for CSS properties that work on the Border control. The following properties are now supported:

.myNicePurpleBorder
{
   border-color: #512BD4; /* Also supports linear-gradient, radial-gradient, named colors etc. */
   border-radius: 10; /* Always maps to RoundRectangle [Radius] internally */
   border-width: 4;
}

Issues Fixed

Partially fixes #27296 to get basic support going, making it become on par with existing support for Frame, Button and ImageButton. It could definitely be expanded upon in the future for Border explicitly, but a discussion is to be had on how that would translate to missing features on the other controls that support borders.

Copy link
Contributor

Hey there @sthewissen! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Feb 3, 2025
@sthewissen sthewissen marked this pull request as ready for review February 3, 2025 08:57
@sthewissen sthewissen requested a review from a team as a code owner February 3, 2025 08:57
@rmarinho
Copy link
Member

rmarinho commented Feb 3, 2025

/rebase

@dotnet dotnet deleted a comment from jsuarezruiz Feb 3, 2025
@dotnet dotnet deleted a comment from azure-pipelines bot Feb 3, 2025
@github-actions github-actions bot force-pushed the sthewissen/border-css branch from 12d1e0c to 21b5e67 Compare February 3, 2025 19:30
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jfversluis jfversluis merged commit c982f38 into dotnet:main Feb 11, 2025
124 checks passed
@bricefriha
Copy link

Much needed, thanks @sthewissen!

@sthewissen sthewissen deleted the sthewissen/border-css branch February 12, 2025 13:52
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-border Border community ✨ Community Contribution
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add CSS support for the Border control
7 participants